Potentially problematic event listener setup #1852
Replies: 1 comment
-
|
Sharp eye! Fixed here: #1973 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Was randomly browsing the code and noticed this:
fizzy/app/javascript/controllers/lightbox_controller.js
Lines 6 to 12 in 372d46f
.bind(this)returns a new function, so the original listener won't be removed whendisconnectis called.Beta Was this translation helpful? Give feedback.
All reactions