More realistic Accept-Language header

djmb · djmb · commit 92b50d184176 · 2023-06-07T08:22:45.000+01:00
We had an example of a 500 response to imageproxy. Changing the Accept-Language header from `*` to a more realistic `en-US,en;q=0.8` fixed the issue. See https://3.basecamp.com/2914079/buckets/27/card_tables/cards/6211371753
diff --git a/imageproxy.go b/imageproxy.go
@@ -176,7 +176,7 @@ func (p *Proxy) serveImage(w http.ResponseWriter, r *http.Request) {
 
 	actualReq, _ := http.NewRequest("GET", req.String(), nil)
 	actualReq.Header.Set("Accept", "*/*")
-	actualReq.Header.Set("Accept-Language", "*")
+	actualReq.Header.Set("Accept-Language", "en-US,en;q=0.8")
 	if p.UserAgent != "" {
 		actualReq.Header.Set("User-Agent", p.UserAgent)
 	}

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ func (p Proxy) serveImage(w http.ResponseWriter, r http.Request) {`
`176`	`176`
`177`	`177`	`actualReq, _ := http.NewRequest("GET", req.String(), nil)`
`178`	`178`	`actualReq.Header.Set("Accept", "/")`
`179`		`- actualReq.Header.Set("Accept-Language", "*")`
	`179`	`+ actualReq.Header.Set("Accept-Language", "en-US,en;q=0.8")`
`180`	`180`	`if p.UserAgent != "" {`
`181`	`181`	`actualReq.Header.Set("User-Agent", p.UserAgent)`
`182`	`182`	`}`