Configuration API #504
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { deepMerge } from "../helpers/hash_helper" | ||
|
|
||
| export default class Configuration { | ||
| #tree = {} | ||
|
|
||
| constructor(...configs) { | ||
| this.merge(...configs) | ||
| } | ||
|
|
||
| merge(...configs) { | ||
| return this.#tree = configs.reduce(deepMerge, this.#tree) | ||
| } | ||
|
|
||
| get(path) { | ||
| const keys = path.split(".") | ||
| return keys.reduce((node, key) => node[key], this.#tree) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import Configuration from "./configuration" | ||
|
|
||
| const global = new Configuration({ | ||
| attachmentTagName: "action-text-attachment" | ||
| }) | ||
|
|
||
| const presets = new Configuration({ | ||
| default: { | ||
| attachments: true, | ||
| markdown: true, | ||
| multiLine: true, | ||
| richText: true, | ||
| toolbar: true, | ||
| } | ||
| }) | ||
|
|
||
| export default { | ||
| global, | ||
| presets, | ||
| configure({ global: newGlobal, ...newPresets }) { | ||
| if (newGlobal) { | ||
| global.merge(newGlobal) | ||
| } | ||
| presets.merge(newPresets) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import Configuration from "../config/configuration" | ||
| import Lexxy from "../config/lexxy" | ||
| import { dasherize } from "../helpers/string_helper" | ||
|
|
||
| export default class EditorConfiguration { | ||
| #editorElement | ||
| #config | ||
|
|
||
| constructor(editorElement) { | ||
| this.#editorElement = editorElement | ||
| this.#config = new Configuration( | ||
| Lexxy.presets.get("default"), | ||
| Lexxy.presets.get(editorElement.preset), | ||
| this.#overrides | ||
| ) | ||
| } | ||
|
|
||
| get(path) { | ||
| return this.#config.get(path) | ||
| } | ||
|
|
||
| get #overrides() { | ||
| const overrides = {} | ||
| for (const option of this.#defaultOptions) { | ||
| const attribute = dasherize(option) | ||
| if (this.#editorElement.hasAttribute(attribute)) { | ||
| overrides[option] = this.#parseAttribute(attribute) | ||
| } | ||
| } | ||
| return overrides | ||
| } | ||
|
|
||
| get #defaultOptions() { | ||
| return Object.keys(Lexxy.presets.get("default")) | ||
| } | ||
|
|
||
| #parseAttribute(attribute) { | ||
| const value = this.#editorElement.getAttribute(attribute) | ||
zachasme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| try { | ||
| return JSON.parse(value) | ||
| } catch { | ||
| return value | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should include a reference to
Lexxy.globaland the option to configure tag names, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! ✅
What do you think of the public interface? Right now I only expose
Lexxy.configurewhich re-routes it's input toglobal/presets.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good 👍