add validations for command.expose

Author: DannyBen

lib/bashly/config_validator.rb

@@ -117,6 +117,7 @@ def assert_command(key, value)
 
       assert_boolean "#{key}.private", value['private']
       assert_boolean "#{key}.default", value['default']
+      assert_boolean "#{key}.expose", value['expose']
       assert_version "#{key}.version", value['version']
       assert_catch_all "#{key}.catch_all", value['catch_all']
       assert_string_or_array "#{key}.alias", value['alias']
@@ -141,11 +142,16 @@ def assert_command(key, value)
         refute repeatable_arg, "#{key}.catch_all makes no sense with repeatable arg (#{repeatable_arg})"
       end
 
+      if value['expose']
+        assert value['commands'], "#{key}.expose makes no sense without commands"
+      end
+
       if key == "root"
         refute value['alias'], "#{key}.alias makes no sense"
         refute value['group'], "#{key}.group makes no sense"
         refute value['default'], "#{key}.default makes no sense"
         refute value['private'], "#{key}.private makes no sense"
+        refute value['expose'], "#{key}.expose makes no sense"
       else
         refute value['version'], "#{key}.version makes no sense"
         refute value['extensible'], "#{key}.extensible makes no sense"

spec/approvals/validations/command_expose_no_commands

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.commands[0].expose makes no sense without commands>

spec/approvals/validations/command_expose_not_boolean

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.commands[0].expose must be a boolean>

spec/approvals/validations/root_expose

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.expose makes no sense>

spec/fixtures/script/validations.yml

@@ -36,6 +36,23 @@
     help: catch_all.required should be boolean
     required: 1
 
+:command_expose_not_boolean:
+  name: invalid
+  help: expose should be boolean
+  commands:
+  - name: config
+    expose: 1
+    commands:
+    - name: edit
+    - name: show
+
+:command_expose_no_commands:
+  name: invalid
+  help: expose without commands makes no sense
+  commands:
+  - name: config
+    expose: true
+
 :command_extensible:
   name: invalid
   help: extensible shuold be a boolean or string
@@ -82,7 +99,6 @@
   - name: api_key
     required: 1
 
-
 :flag_long:
   name: invalid
   help: the long flag is not in the form of --force
@@ -176,6 +192,13 @@
   help: root cannot have default
   default: true
 
+:root_expose:
+  name: invalid
+  help: root cannot have expose
+  expose: true
+  commands:
+  - name: config
+
 :root_private:
   name: invalid
   help: root cannot have private