- Make generated scripts compatible with bash strict mode

Author: DannyBen

examples/config-ini/src/lib/config.sh

@@ -22,6 +22,7 @@ config_init() {
 config_get() {
   key=$1
   regex="^$key\s*=\s*(.+)$"
+  value=''
 
   config_init
 
@@ -122,5 +123,5 @@ config_keys() {
 #   fi
 #
 config_has_key() {
-  [[ $(config_get "$1") ]]
+  [[ $(config_get "${1:-}") ]]
 }

examples/environment-variables/src/verify_command.sh

@@ -4,6 +4,6 @@ echo "# you can edit it freely and regenerate (it will not be overwritten)"
 inspect_args
 
 echo "environment:"
-echo "- API_KEY=$API_KEY"
-echo "- ENVIRONMENT=$ENVIRONMENT"
-echo "- MY_SECRET=$MY_SECRET"
+echo "- API_KEY=${API_KEY:-}"
+echo "- ENVIRONMENT=${ENVIRONMENT:-}"
+echo "- MY_SECRET=${MY_SECRET:-}"

examples/yaml/src/root_command.sh

@@ -1,6 +1,6 @@
-filename=${args[filename]}
-variable=${args[variable]}
-prefix=${args[--prefix]}
+filename=${args[filename]:-}
+variable=${args[variable]:-}
+prefix=${args[--prefix]:-}
 
 if [[ $variable ]]; then
   eval "$(yaml_load "$filename" "$prefix")"

lib/bashly/commands/generate.rb

@@ -13,6 +13,7 @@ class Generate < Base
 
       environment "BASHLY_SOURCE_DIR", "The path containing the bashly configuration and source files [default: src]"
       environment "BASHLY_TARGET_DIR", "The path to use for creating the bash script [default: .]"
+      environment "BASHLY_STRICT", "When not empty, enable bash strict mode (set -euo pipefail)"
 
       example "bashly generate --force"
       example "bashly generate --wrap my_function"

lib/bashly/views/command/catch_all_filter.erb

@@ -1,6 +1,6 @@
 # :command.catch_all_filter
 % if catch_all_required?
-if [[ ${#other_args[@]} -eq 0 ]]; then
+if [[ ! -v other_args[@] ]]; then
   printf "<%= strings[:missing_required_argument] % { arg: catch_all_label, usage: usage_string } %>\n"
   exit 1
 fi

lib/bashly/views/command/command_filter.erb

@@ -1,6 +1,6 @@
 # :command.command_filter
 % if commands.any?
-action=$1
+action=${1:-}
 
 case $action in
 -* )

lib/bashly/views/command/default_assignments.erb

@@ -1,7 +1,7 @@
 # :command.default_assignments
 % default_args.each do |arg|
-[[ -n ${args[<%= arg.name %>]} ]] || args[<%= arg.name %>]="<%= arg.default %>"
+[[ -n ${args[<%= arg.name %>]:-} ]] || args[<%= arg.name %>]="<%= arg.default %>"
 % end
 % default_flags.each do |flag|
-[[ -n ${args[<%= flag.long %>]} ]] || args[<%= flag.long %>]="<%= flag.default %>"
+[[ -n ${args[<%= flag.long %>]:-} ]] || args[<%= flag.long %>]="<%= flag.default %>"
 % end

lib/bashly/views/command/environment_variables_filter.erb

@@ -6,7 +6,7 @@ export <%= env_var.name.upcase %>="${<%= env_var.name.upcase %>:-<%= env_var.def
 % end
 % if required_environment_variables.any?
 % required_environment_variables.each do |env_var|
-if [[ -z "$<%= env_var.name.upcase %>" ]]; then
+if [[ -z "${<%= env_var.name.upcase %>:-}" ]]; then
   printf "<%= strings[:missing_required_environment_variable] % { var: env_var.name.upcase } %>\n"
   exit 1
 fi

lib/bashly/views/command/fixed_flags_filter.erb

@@ -1,5 +1,5 @@
 # :command.fixed_flag_filter
-case "$1" in
+case "${1:-}" in
 % if short_flag_exist? "-v"
 --version )
 % else

lib/bashly/views/command/initialize.erb

@@ -2,7 +2,7 @@
 initialize() {
   version="<%= version %>"
   long_usage=''
-  set -e
+  <%= ENV['BASHLY_STRICT'] ? "set -euo pipefail" : "set -e" %>
 
 <%= load_user_file("initialize.sh", placeholder: false).indent 2 %>
 }