rubocop + composition spec refactoring

Author: DannyBen

lib/bashly/script/argument.rb

@@ -4,7 +4,7 @@ module Bashly
   module Script
     class Argument < Base
       include Introspection::Validate
-      
+
       class << self
         def option_keys
           @option_keys ||= %i[

spec/bashly/commands/preview_spec.rb

@@ -21,5 +21,3 @@
     end
   end
 end
-
-

spec/bashly/integration/examples_spec.rb

@@ -24,10 +24,10 @@
   # Allow up to a certain string distance from the approval text in CI
   leeway = ENV['CI'] ? 40 : 0
 
-  # For certain examples, allow some exceptions (replacements) since they 
+  # For certain examples, allow some exceptions (replacements) since they
   # are too volatile (e.g. line number changes)
   exceptions = {
-    'examples/stacktrace' => [/download:\d+/, 'download:<line>'],
+    'examples/stacktrace'    => [/download:\d+/, 'download:<line>'],
     'examples/render-mandoc' => [/Version 0.1.0.*download\(1\)/, '<footer>'],
   }
 

spec/bashly/script/argument_spec.rb

@@ -9,9 +9,7 @@
   describe 'composition' do
     it 'includes the necessary modules' do
       modules = [Script::Introspection::Validate]
-      modules.each do |mod|
-        expect(described_class.ancestors).to include(mod)
-      end
+      expect(described_class.ancestors).to include(*modules)
     end
   end
 

spec/bashly/script/command_spec.rb

@@ -19,11 +19,9 @@
         Script::Introspection::Flags,
         Script::Introspection::Variables,
         Script::Introspection::Visibility,
-        Completions::Command
+        Completions::Command,
       ]
-      modules.each do |mod|
-        expect(described_class.ancestors).to include(mod)
-      end
+      expect(described_class.ancestors).to include(*modules)
     end
   end
 

spec/bashly/script/environment_variable_spec.rb

@@ -9,9 +9,7 @@
   describe 'composition' do
     it 'includes the necessary modules' do
       modules = [Script::Introspection::Visibility, Script::Introspection::Validate]
-      modules.each do |mod|
-        expect(described_class.ancestors).to include(mod)
-      end
+      expect(described_class.ancestors).to include(*modules)
     end
   end
 

spec/bashly/script/flag_spec.rb

@@ -12,9 +12,7 @@
         Script::Introspection::Visibility, Script::Introspection::Validate,
         Completions::Flag
       ]
-      modules.each do |mod|
-        expect(described_class.ancestors).to include(mod)
-      end
+      expect(described_class.ancestors).to include(*modules)
     end
   end
 

spec/bashly/script/introspection/validate_spec.rb

@@ -19,7 +19,7 @@
       let(:fixture) { :validate_array }
 
       it 'returns it as is' do
-        expect(subject.validate).to eq ['file_exists', 'file_is_writable']
+        expect(subject.validate).to eq %w[file_exists file_is_writable]
       end
     end
   end
@@ -29,7 +29,7 @@
       expect(subject.validate?).to be false
     end
 
-    context 'when validations are defined' do      
+    context 'when validations are defined' do
       let(:fixture) { :validate_string }
 
       it 'returns true' do