fixes

Author: DannyBen

.github/workflows/static-analysis.yml

@@ -5,7 +5,7 @@ on:
 
 jobs:
   static_analysis:
-    name: Example files static analysis
+    name: Run shellcheck and shfmt
 
     runs-on: ubuntu-latest
 
@@ -52,7 +52,7 @@ jobs:
       run: bundle exec run shfmt fixtures
 
   json_schema:
-    name: JSON schemas validation
+    name: Validate JSON schemas
 
     runs-on: ubuntu-latest
 
@@ -100,18 +100,3 @@ jobs:
 
     - name: Run codespell
       run: codespell
-
-  docker:
-    name: Docker smoke test
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v4
-
-    - name: Build the image
-      run: docker compose build bash
-
-    - name: Test pandoc presence
-      run: docker compose run pandoc-test

lib/bashly/views/argument/validations.gtx

@@ -3,7 +3,7 @@ if validate
 
   if repeatable
     > if [[ -v args['{{ name }}'] ]]; then
-    >   read -a values <<<"${args['{{ name }}']}"
+    >   read -r -a values <<<"${args['{{ name }}']}"
     >   for value in "${values[@]}"; do
     >     if [[ -n $(validate_{{ validate }} "$value") ]]; then
     >       printf "{{ strings[:validation_error] }}\n" "{{ name.upcase }}" "$(validate_{{ validate }} "$value")" >&2

lib/bashly/views/command/whitelist_filter.gtx

@@ -3,7 +3,7 @@ if whitelisted_args.any? or whitelisted_flags.any?
 
   whitelisted_args.each do |arg|
     if arg.repeatable
-      > read -a input_array <<<"${args['{{ arg.name }}']}"
+      > read -r -a input_array <<<"${args['{{ arg.name }}']}"
       > for i in "${input_array[@]}"; do
       >   if [[ ! $i =~ ^({{ arg.allowed.join '|' }})$ ]]; then
       >     printf "%s\n" "{{ strings[:disallowed_argument] % { name: arg.name, allowed: arg.allowed.join(', ') } }}" >&2
@@ -22,7 +22,7 @@ if whitelisted_args.any? or whitelisted_flags.any?
 
   whitelisted_flags.each do |flag|
     if flag.repeatable
-      > read -a input_array <<<"${args['{{ flag.name }}']}"
+      > read -r -a input_array <<<"${args['{{ flag.name }}']}"
       > for i in "${input_array[@]}"; do
       >   if [[ ! $i =~ ^({{ flag.allowed.join '|' }})$ ]]; then
       >     printf "%s\n" "{{ strings[:disallowed_flag] % { name: flag.name, allowed: flag.allowed.join(', ') } }}" >&2

lib/bashly/views/flag/validations.gtx

@@ -3,7 +3,7 @@ if validate
 
   if repeatable
     > if [[ -v args['{{ long }}'] ]]; then
-    >   read -a values <<<"${args['{{ long }}']}"
+    >   read -r -a values <<<"${args['{{ long }}']}"
     >   for value in "${values[@]}"; do
     >     if [[ -n $(validate_{{ validate }} "$value") ]]; then
     >       printf "{{ strings[:validation_error] }}\n" "{{ usage_string }}" "$(validate_{{ validate }} "$value")" >&2

spec/fixtures/workspaces/repeatable-escaping/src/root_command.sh

@@ -1,14 +1,14 @@
 inspect_args
 
 if [[ -v args[term] ]]; then
-  read -a terms <<< "${args['term']}"
+  read -r -a terms <<<"${args['term']}"
   for t in "${terms[@]}"; do
     echo "[TERM] --> ${t}"
   done
 fi
 
 if [[ -v args[--search] ]]; then
-  read -a terms <<< "${args['--search']}"
+  read -r -a terms <<<"${args['--search']}"
   for t in "${terms[@]}"; do
     echo "[--serach] --> ${t}"
   done