migrate from rspec_fixtures to rspec_approvals

Author: DannyBen

Gemfile

@@ -3,7 +3,7 @@ source "https://rubygems.org"
 gem 'byebug'
 gem 'lp'
 gem 'rspec'
-gem 'rspec_fixtures'
+gem 'rspec_approvals'
 gem 'runfile'
 gem 'runfile-tasks'
 gem 'simplecov'

spec/bashly/bin_spec.rb

@@ -4,12 +4,12 @@
   subject { CLI.runner }
 
   it "shows list of commands" do
-    expect{ subject.run }.to output_fixture('cli/commands')
+    expect{ subject.run }.to output_approval('cli/commands')
   end
 
   context "on error" do
     it "displays it nicely" do
-      expect(`bin/bashly generate 2>&1`).to match_fixture('cli/error')
+      expect(`bin/bashly generate 2>&1`).to match_approval('cli/error')
     end
   end
 end

spec/bashly/commands/add_spec.rb

@@ -7,13 +7,13 @@
 
   context "with --help" do
     it "shows long usage" do
-      expect{ subject.run %w[add --help] }.to output_fixture('cli/add/help')
+      expect{ subject.run %w[add --help] }.to output_approval('cli/add/help')
     end
   end
 
   context "without arguments" do
     it "shows long usage" do
-      expect{ subject.run %w[add] }.to output_fixture('cli/generate/usage')
+      expect{ subject.run %w[add] }.to output_approval('cli/generate/usage')
     end
   end
 
@@ -25,7 +25,7 @@
     end
 
     it "copies the strings configuration to the user space" do
-      expect { subject.run %w[add strings] }.to output_fixture('cli/add/strings')
+      expect { subject.run %w[add strings] }.to output_approval('cli/add/strings')
       expect(File).to exist(strings_file)
     end
 
@@ -41,8 +41,8 @@
 
     context "when the file exists" do
       it "skips copying it" do
-        expect { subject.run %w[add strings] }.to output_fixture('cli/add/strings')
-        expect { subject.run %w[add strings] }.to output_fixture('cli/add/strings-exist')
+        expect { subject.run %w[add strings] }.to output_approval('cli/add/strings')
+        expect { subject.run %w[add strings] }.to output_approval('cli/add/strings-exist')
       end
     end
   end
@@ -55,7 +55,7 @@
     end
 
     it "copies a sample function to the user space under lib directory" do
-      expect { subject.run %w[add lib] }.to output_fixture('cli/add/lib')
+      expect { subject.run %w[add lib] }.to output_approval('cli/add/lib')
       expect(File).to exist(lib_file)
     end
   end
@@ -68,7 +68,7 @@
     end
 
     it "copies the config.sh lib file to the user space" do
-      expect { subject.run %w[add config] }.to output_fixture('cli/add/config')
+      expect { subject.run %w[add config] }.to output_approval('cli/add/config')
       expect(File).to exist(lib_file)
     end
   end
@@ -81,7 +81,7 @@
     end
 
     it "copies the yaml.sh lib file to the user space" do
-      expect { subject.run %w[add yaml] }.to output_fixture('cli/add/yaml')
+      expect { subject.run %w[add yaml] }.to output_approval('cli/add/yaml')
       expect(File).to exist(lib_file)
     end
   end
@@ -94,7 +94,7 @@
     end
 
     it "copies the colors.sh lib file to the user space" do
-      expect { subject.run %w[add colors] }.to output_fixture('cli/add/colors')
+      expect { subject.run %w[add colors] }.to output_approval('cli/add/colors')
       expect(File).to exist(lib_file)
     end
   end

spec/bashly/commands/generate_spec.rb

@@ -7,7 +7,7 @@
 
   context "with --help" do
     it "shows long usage" do
-      expect{ subject.run %w[generate --help] }.to output_fixture('cli/generate/help')
+      expect{ subject.run %w[generate --help] }.to output_approval('cli/generate/help')
     end
   end
 
@@ -21,18 +21,18 @@
     end
 
     it "generates the cli script" do
-      expect { subject.run %w[generate] }.to output_fixture('cli/generate/no-args')
+      expect { subject.run %w[generate] }.to output_approval('cli/generate/no-args')
       expect(File).to exist(cli_script)
     end
 
     context "when source files already exist" do
       before do
-        expect { subject.run %w[generate] }.to output_fixture('cli/generate/no-args')
+        expect { subject.run %w[generate] }.to output_approval('cli/generate/no-args')
         File.write "#{source_dir}/cli_get_command.sh", "some new user content"
       end
 
       it "does not overwrite them" do
-        expect { subject.run %w[generate] }.to output_fixture('cli/generate/no-args-skip')
+        expect { subject.run %w[generate] }.to output_approval('cli/generate/no-args-skip')
         expect(File.read "#{source_dir}/cli_get_command.sh").to eq "some new user content"
       end
     end
@@ -45,7 +45,7 @@
       end
 
       it "generates the cli script" do
-        expect { subject.run %w[generate] }.to output_fixture('cli/generate/minimal')
+        expect { subject.run %w[generate] }.to output_approval('cli/generate/minimal')
         expect(File).to exist(cli_script)
       end
     end

spec/bashly/commands/init_spec.rb

@@ -6,7 +6,7 @@
 
   context "with --help" do
     it "shows long usage" do
-      expect{ subject.run %w[init --help] }.to output_fixture('cli/init/help')
+      expect{ subject.run %w[init --help] }.to output_approval('cli/init/help')
     end
   end
 
@@ -17,7 +17,7 @@
     let(:template) { File.read template_file }
 
     it "creates a new workspace" do
-      expect{ subject.run %w[init] }.to output_fixture('cli/init/no-args')
+      expect{ subject.run %w[init] }.to output_approval('cli/init/no-args')
       expect(File).to exist(config_file)
       expect(File.read config_file).to eq template
     end
@@ -38,7 +38,7 @@
     let(:template) { File.read template_file }
 
     it "creates a new workspace using the minimal config" do
-      expect{ subject.run %w[init --minimal] }.to output_fixture('cli/init/minimal')
+      expect{ subject.run %w[init --minimal] }.to output_approval('cli/init/minimal')
       expect(File).to exist(config_file)
       expect(File.read config_file).to eq template
     end

spec/bashly/commands/preview_spec.rb

@@ -6,7 +6,7 @@
 
   context "with --help" do
     it "shows long usage" do
-      expect{ subject.run %w[preview --help] }.to output_fixture('cli/preview/help')
+      expect{ subject.run %w[preview --help] }.to output_approval('cli/preview/help')
     end
   end
 
@@ -18,7 +18,7 @@
     end
 
     it "prints the generated cli script" do
-      expect { subject.run %w[preview] }.to output_fixture('cli/preview/no-args')
+      expect { subject.run %w[preview] }.to output_approval('cli/preview/no-args')
         .except(/env bash\n.*\nrun "\$@"/m, "env bash\n...\nrun \"\$@\"")
     end
   end

spec/bashly/integration/examples_spec.rb

@@ -30,7 +30,7 @@
         # This was observed in at least these two cases:
         # - The "+ ..." shell messages driven by `set -x` have no space
         # - The order of our `inspect_args` sometimes differs
-        expect(output).to match_fixture(approval_name).diff(leeway)
+        expect(output).to match_approval(approval_name).diff(leeway)
       end
     end
   end

spec/spec_helper.rb

@@ -23,6 +23,5 @@
 
 RSpec.configure do |c|
   c.include SpecMixin
-  c.fixtures_path = "spec/approvals"
   c.strip_ansi_escape = true
 end