- Fix completions library to not show private flags

Author: DannyBen

lib/bashly/concerns/completions.rb

@@ -9,6 +9,7 @@ def completion_data(command_full_name)
         comps = allowed || completions
         return {} unless comps
 
+
         aliases.to_h do |name|
           prefix = command_full_name
           prefix = "#{prefix}*" unless prefix.end_with? '*'
@@ -62,7 +63,7 @@ def completion_generator
       end
 
       def completion_flag_names
-        flags.map(&:name) + flags.map(&:short)
+        public_flags.map(&:name) + public_flags.map(&:short)
       end
 
       def completion_allowed_args

spec/approvals/fixtures/completions-private

@@ -1,4 +1,4 @@
-+ bundle exec bashly add completions_yaml
++ bundle exec bashly add completions_yaml --force
 created ./completions.yml
 
 This file can be converted to a completions script using the completely gem.
@@ -13,8 +13,12 @@ private:
 - c
 - connect
 private connect:
+- "--force"
 - "--help"
+- "-f"
 - "-h"
 private c:
+- "--force"
 - "--help"
+- "-f"
 - "-h"

spec/fixtures/workspaces/completions-private/src/bashly.yml

@@ -5,6 +5,15 @@ commands:
 - name: connect
   alias: c
   help: Connect to the metaverse
+  flags:
+    - long: --force
+      short: -f
+    # Private flag below - should not be present in completions
+    - long: --hidden-flag
+      short: -d
+      private: true
+
+# Private commands below - should not be present in completions
 - name: connect-ftp
   help: Connect via FTP
   alias: cf

spec/fixtures/workspaces/completions-private/test.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
 
-rm -f ./completions.yml
-
 set -x
-bundle exec bashly add completions_yaml
+bundle exec bashly add completions_yaml --force
 cat completions.yml