Merge pull request #235 from DannyBen/fix/parents-revalidation

Fix parents revalidation issue

Author: DannyBen

lib/bashly/script/command.rb

@@ -17,6 +17,9 @@ def option_keys
         end
       end
 
+      attr_accessor :parent_command
+      attr_writer :parents
+
       # Returns the name to be used as an action.
       # - If it is the root command, the action is "root"
       # - Else, it is all the parents, except the first one (root) joined
@@ -100,9 +103,10 @@ def command_names
       def commands
         return [] unless options["commands"]
         options["commands"].map do |options|
-          options['parents'] = parents + [name]
-          options['parent_command'] = self
-          Command.new options
+          result = Command.new options
+          result.parents = parents + [name]
+          result.parent_command = self
+          result
         end
       end
 
@@ -182,15 +186,10 @@ def group_string
         end
       end
 
-      # Returns the Command instance of the direct parent
-      def parent_command
-        options['parent_command']
-      end
-
       # Returns an array of all parents. For example, the command 
       # "docker container run" will have [docker, container] as its parents
       def parents
-        options['parents'] || []
+        @parents ||= []
       end
 
       # Returns only commands that are not private

spec/bashly/script/command_spec.rb

@@ -3,7 +3,11 @@
 describe Script::Command do
   let(:fixture) { :basic_command }
   fixtures = load_fixture('script/commands')
-  subject { described_class.new fixtures[fixture] }
+  subject do
+    result = described_class.new fixtures[fixture]
+    result.parents = result.options['parents']
+    result
+  end
 
   describe '#action_name' do
     context "when it is the root command" do