fix validations for repeatable args and flags

Author: DannyBen

lib/bashly/views/argument/validations.gtx

@@ -1,5 +1,4 @@
 if validate
-
   = view_marker
 
   if repeatable
@@ -17,7 +16,7 @@ if validate
     >   printf "{{ strings[:validation_error] }}\n" "{{ name.upcase }}" "$(validate_{{ validate }} "${args['{{ name }}']:-}")" >&2
     >   exit 1
     > fi
-    > 
+    >
   end
 
 end

lib/bashly/views/flag/validations.gtx

@@ -1,11 +1,22 @@
 if validate
-
   = view_marker
 
-  > if [[ -v args['{{ long }}'] && -n $(validate_{{ validate }} "${args['{{ long }}']:-}") ]]; then
-  >   printf "{{ strings[:validation_error] }}\n" "{{ usage_string }}" "$(validate_{{ validate }} "${args['{{ long }}']:-}")" >&2
-  >   exit 1
-  > fi
-  > 
+  if repeatable
+    > if [[ -v args['{{ long }}'] ]]; then
+    >   eval "values=(${args['{{ long }}']})"
+    >   for value in "${values[@]}"; do
+    >     if [[ -n $(validate_{{ validate }} "$value") ]]; then
+    >       printf "{{ strings[:validation_error] }}\n" "{{ usage_string }}" "$(validate_{{ validate }} "$value")" >&2
+    >       exit 1
+    >     fi
+    >   done
+    > fi
+  else
+    > if [[ -v args['{{ long }}'] && -n $(validate_{{ validate }} "${args['{{ long }}']:-}") ]]; then
+    >   printf "{{ strings[:validation_error] }}\n" "{{ usage_string }}" "$(validate_{{ validate }} "${args['{{ long }}']:-}")" >&2
+    >   exit 1
+    > fi
+    >
+  end
 
 end

spec/approvals/fixtures/repeatable-arg-validations

@@ -12,17 +12,23 @@ args: none
 # you can edit it freely and regenerate (it will not be overwritten)
 args:
 - ${args[number]} = "1"
++ ./cli 1.1
+validation error in NUMBER:
+must be an integer
++ ./cli a
+validation error in NUMBER:
+must be an integer
 + ./cli 1 2
 # this file is located in 'src/root_command.sh'
 # you can edit it freely and regenerate (it will not be overwritten)
 args:
 - ${args[number]} = "1" "2"
-+ ./cli 1.1
-validation error in NUMBER:
-must be an integer
 + ./cli 1.1 2
 validation error in NUMBER:
 must be an integer
 + ./cli 1 2.2
 validation error in NUMBER:
 must be an integer
++ ./cli 1 a
+validation error in NUMBER:
+must be an integer

spec/approvals/fixtures/repeatable-flag-validations

@@ -0,0 +1,34 @@
++ bundle exec bashly generate
+creating user files in src
+created src/root_command.sh
+created ./cli
+run ./cli --help to test your bash script
++ ./cli
+# this file is located in 'src/root_command.sh'
+# you can edit it freely and regenerate (it will not be overwritten)
+args: none
++ ./cli --number 1
+# this file is located in 'src/root_command.sh'
+# you can edit it freely and regenerate (it will not be overwritten)
+args:
+- ${args[--number]} = "1"
++ ./cli --number 1.1
+validation error in --number, -n NUMBER:
+must be an integer
++ ./cli --number a
+validation error in --number, -n NUMBER:
+must be an integer
++ ./cli --number 1 --number 2
+# this file is located in 'src/root_command.sh'
+# you can edit it freely and regenerate (it will not be overwritten)
+args:
+- ${args[--number]} = "1" "2"
++ ./cli --number 1.1 --number 2
+validation error in --number, -n NUMBER:
+must be an integer
++ ./cli --number 1 --number 2.2
+validation error in --number, -n NUMBER:
+must be an integer
++ ./cli --number 1 --number a
+validation error in --number, -n NUMBER:
+must be an integer

spec/fixtures/workspaces/repeatable-arg-validations/test.sh

@@ -10,7 +10,9 @@ bundle exec bashly generate
 
 ./cli
 ./cli 1
-./cli 1 2
 ./cli 1.1
+./cli a
+./cli 1 2
 ./cli 1.1 2
 ./cli 1 2.2
+./cli 1 a

spec/fixtures/workspaces/repeatable-flag-validations/.gitignore

@@ -0,0 +1,2 @@
+cli
+src/*.sh

spec/fixtures/workspaces/repeatable-flag-validations/README.md

@@ -0,0 +1,3 @@
+This fixture tests that validations on repeatable args validate all arguments
+**regardless of order**.
+Reference issue: https://github.com/DannyBen/bashly/issues/311

spec/fixtures/workspaces/repeatable-flag-validations/src/bashly.yml

@@ -0,0 +1,9 @@
+name: cli
+help: all arguments must be integers
+
+flags:
+- long: --number
+  short: -n
+  arg: NUMBER
+  repeatable: true
+  validate: integer

spec/fixtures/workspaces/repeatable-flag-validations/src/lib/validate_integer.sh

@@ -0,0 +1,3 @@
+validate_integer() {
+  [[ "$1" =~ ^[0-9]+$ ]] || echo "must be an integer"
+}

spec/fixtures/workspaces/repeatable-flag-validations/test.sh

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash
+
+rm -f ./cli
+rm -f ./src/initialize.sh
+rm -f ./src/root_command.sh
+
+set -x
+
+bundle exec bashly generate
+
+./cli
+./cli --number 1
+./cli --number 1.1
+./cli --number a
+./cli --number 1 --number 2
+./cli --number 1.1 --number 2
+./cli --number 1 --number 2.2
+./cli --number 1 --number a