add validations for command.filters

Author: DannyBen

lib/bashly/config_validator.rb

@@ -72,6 +72,14 @@ def assert_extensible(key, value)
         "#{key} must be a boolean or a string" 
     end
 
+    def assert_filters(key, value)
+      return unless value
+      assert [Array, String].include?(value.class),
+        "#{key} must be an array or a string" 
+
+      assert_array key, value, of: :string if value.is_a? Array
+    end
+
     def assert_arg(key, value)
       assert_hash key, value
       assert_string "#{key}.name", value['name']
@@ -129,6 +137,7 @@ def assert_command(key, value)
       assert_version "#{key}.version", value['version']
       assert_catch_all "#{key}.catch_all", value['catch_all']
       assert_extensible "#{key}.extensible", value['extensible']
+      assert_filters "#{key}.filters", value['filters']
 
       assert_array "#{key}.args", value['args'], of: :arg
       assert_array "#{key}.flags", value['flags'] , of: :flag

spec/approvals/validations/invalid_filters_array

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.filters must be an array or a string>

spec/approvals/validations/invalid_filters_type

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.filters must be an array or a string>

spec/fixtures/script/validations.yml

@@ -61,3 +61,15 @@
   args:
   - name: --user
 
+:invalid_filters_type:
+  name: invalid
+  help: invalid since command.filters should be an array or string
+  filters: 1
+
+:invalid_filters_array:
+  name: invalid
+  help: invalid since command.filters in array form must have strings
+  filters:
+    one: two
+    three: four
+