- Exit gracefully if bash version is < 4

DannyBen · web-flow · commit 8b442a8d77f3 · 2021-08-25T08:19:37.000+03:00
diff --git a/examples/catch-all-advanced/cli b/examples/catch-all-advanced/cli
@@ -406,7 +406,12 @@ cli_upload_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/catch-all/download b/examples/catch-all/download
@@ -134,7 +134,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/colors/colorly b/examples/colors/colorly
@@ -167,7 +167,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/command-default/ftp b/examples/command-default/ftp
@@ -344,7 +344,12 @@ ftp_download_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/command-groups/ftp b/examples/command-groups/ftp
@@ -505,7 +505,12 @@ ftp_logout_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/commands-nested/cli b/examples/commands-nested/cli
@@ -745,7 +745,12 @@ cli_file_edit_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/commands/cli b/examples/commands/cli
@@ -415,7 +415,12 @@ cli_upload_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/completions/cli b/examples/completions/cli
@@ -522,7 +522,12 @@ cli_upload_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/config-ini/configly b/examples/config-ini/configly
@@ -594,7 +594,12 @@ configly_list_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/custom-includes/download b/examples/custom-includes/download
@@ -139,7 +139,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/custom-strings/download b/examples/custom-strings/download
@@ -155,7 +155,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/default-values/convert b/examples/default-values/convert
@@ -155,7 +155,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/dependencies/cli b/examples/dependencies/cli
@@ -304,7 +304,12 @@ cli_upload_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/docker-like/docker b/examples/docker-like/docker
@@ -612,7 +612,12 @@ docker_image_ls_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/environment-variables/cli b/examples/environment-variables/cli
@@ -241,7 +241,12 @@ cli_verify_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/extensible-delegate/mygit b/examples/extensible-delegate/mygit
@@ -306,7 +306,12 @@ mygit_pull_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/extensible/cli b/examples/extensible/cli
@@ -347,7 +347,12 @@ cli_download_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/footer/download b/examples/footer/download
@@ -130,7 +130,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/git-like/git b/examples/git-like/git
@@ -326,7 +326,12 @@ git_commit_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/minimal/download b/examples/minimal/download
@@ -159,7 +159,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/minus-v/cli b/examples/minus-v/cli
@@ -142,7 +142,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/multiline/multi b/examples/multiline/multi
@@ -345,7 +345,12 @@ multi_regular_parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/whitelist/login b/examples/whitelist/login
@@ -204,7 +204,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/examples/yaml/yaml b/examples/yaml/yaml
@@ -219,7 +219,12 @@ parse_requirements() {
 initialize() {
   version="0.1.0"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "bash version 4 or higher is required\n"
+    exit 1
+  fi
 
   # :src/initialize.sh
   # Code here runs inside the initialize() function
diff --git a/lib/bashly/commands/add.rb b/lib/bashly/commands/add.rb
@@ -13,7 +13,7 @@ class Add < Base
 
       option "-f --force", "Overwrite existing files"
 
-      param "FORMAT", "Output format, can be one of:\n  function : generate a function file to be included in your script.\n  script   : generate a standalone bash completions script\n  yaml     : generate a yaml compatible with 'completely'"
+      param "FORMAT", "Output format, can be one of:\n  function : generate a function file to be included in your script.\n  script   : generate a standalone bash completions script.\n  yaml     : generate a yaml compatible with completely."
       param "OUTPUT", "For the 'comp function' command: Name of the generated function.\nFor the 'comp script' or 'comp yaml' commands: path to output file.\nIn all cases, this is optional and will have sensible defaults."
 
       command "strings", "Copy an additional configuration file to your project, allowing you to customize all the tips and error strings."
diff --git a/lib/bashly/templates/lib/config.sh b/lib/bashly/templates/lib/config.sh
@@ -17,7 +17,7 @@ config_init() {
   [[ -f "$CONFIG_FILE" ]] || touch "$CONFIG_FILE"
 }
 
-# Get a value from the config
+# Get a value from the config.
 # Usage: result=$(config_get hello)
 config_get() {
   key=$1
@@ -66,7 +66,7 @@ config_set() {
   printf "%b\n" "$output" > "$CONFIG_FILE"
 }
 
-# Delete a key from teh config.
+# Delete a key from the config.
 # Usage: config_del key
 config_del() {
   key=$1
@@ -92,7 +92,7 @@ config_show() {
   cat "$CONFIG_FILE"
 }
 
-# Return an array of the keys in the config file
+# Return an array of the keys in the config file.
 # Usage:
 #
 #   for k in $(config_keys); do
@@ -114,7 +114,7 @@ config_keys() {
   echo "${keys[@]}"
 }
 
-# Returns true if the specified key exists in the config file
+# Returns true if the specified key exists in the config file.
 # Usage:
 #
 #   if config_has_key "key" ; then
diff --git a/lib/bashly/templates/strings.yml b/lib/bashly/templates/strings.yml
@@ -31,3 +31,4 @@ missing_required_environment_variable: "missing required environment variable: %
 missing_dependency: "missing dependency: %{dependency}"
 disallowed_flag: "%{name} must be one of: %{allowed}"
 disallowed_argument: "%{name} must be one of: %{allowed}"
+unsupported_bash_version: "bash version 4 or higher is required"
diff --git a/lib/bashly/views/command/initialize.erb b/lib/bashly/views/command/initialize.erb
@@ -2,7 +2,12 @@
 initialize() {
   version="<%= version %>"
   long_usage=''
-  set -e  
+  set -e
+
+  if [[ "${BASH_VERSINFO:-0}" -lt 4 ]]; then
+    printf "<%= strings[:unsupported_bash_version] -%>\n"
+    exit 1
+  fi
 
 <%= load_user_file("initialize.sh", placeholder: false).indent 2 %>
 }
diff --git a/spec/approvals/bash/error b/spec/approvals/bash/error
diff --git a/spec/approvals/cli/add/help b/spec/approvals/cli/add/help
diff --git a/spec/bashly/bash_spec.rb b/spec/bashly/bash_spec.rb
diff --git a/spec/fixtures/workspaces/flag-args-with-dash/argflag b/spec/fixtures/workspaces/flag-args-with-dash/argflag
