Merge pull request #345 from DannyBen/add/command-name-validation

Add command.name validation

Author: DannyBen

lib/bashly/config_validator.rb

@@ -157,6 +157,11 @@ def assert_command(key, value)
       assert_extensible "#{key}.extensible", value['extensible']
       assert_dependencies "#{key}.dependencies", value['dependencies']
 
+      assert value['name'].match(/^[a-z0-9_-]+$/),
+        "#{key}.name must only contain lowercase alphanumeric characters, hyphens and underscores"
+
+      refute value['name'].start_with?('-'), "#{key}.name must not start with a hyphen"
+
       assert_array "#{key}.args", value['args'], of: :arg
       assert_array "#{key}.flags", value['flags'], of: :flag
       assert_array "#{key}.commands", value['commands'], of: :command

spec/approvals/validations/command_name_hyphen

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.name must not start with a hyphen>

spec/approvals/validations/command_name_uppercase

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.name must only contain lowercase alphanumeric characters, hyphens and underscores>

spec/fixtures/script/validations.yml

@@ -109,6 +109,14 @@
   help: command.function must match /[a-z0-9_]+/
   function: myCamelCaseFunction
 
+:command_name_uppercase:
+  name: INVALID
+  help: command.name must match /[a-z0-9_\-]+/
+
+:command_name_hyphen:
+  name: -invalid
+  help: command.name must not start with a hyphen
+
 :command_version:
   name: invalid
   help: version should be a string or a number