add validations for new completions

Author: DannyBen

lib/bashly/config_validator.rb

@@ -61,6 +61,8 @@ def assert_flag(key, value)
       assert_hash key, value, Script::Flag.option_keys
       assert value['short'] || value['long'], "#{key} must have at least one of long or short name"
 
+      refute value['allowed'] && value['completions'], "#{key} cannot have both allowed and completions"
+
       assert_optional_string "#{key}.long", value['long']
       assert_optional_string "#{key}.short", value['short']
       assert_optional_string "#{key}.help", value['help']
@@ -72,6 +74,7 @@ def assert_flag(key, value)
       assert_boolean "#{key}.required", value['required']
       assert_array "#{key}.allowed", value['allowed'], of: :string
       assert_array "#{key}.conflicts", value['conflicts'], of: :string
+      assert_array "#{key}.completions", value['completions'], of: :string
 
       assert value['long'].match(/^--[a-zA-Z0-9_\-]+$/), "#{key}.long must be in the form of '--name'" if value['long']
       assert value['short'].match(/^-[a-zA-Z0-9]$/), "#{key}.short must be in the form of '-n'" if value['short']
@@ -86,6 +89,10 @@ def assert_flag(key, value)
       if value['allowed']
         assert value['arg'], "#{key}.allowed does not make sense without arg"
       end
+
+      if value['completions']
+        assert value['arg'], "#{key}.completions does not make sense without arg"
+      end
     end
 
     def assert_env_var(key, value)

spec/approvals/validations/flag_allowed_and_completions

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.flags[0] cannot have both allowed and completions>

spec/approvals/validations/flag_completions_without_arg

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.flags[0].completions does not make sense without arg>

spec/fixtures/script/validations.yml

@@ -146,6 +146,21 @@
   - long: --role
     allowed: [admin, noob]
 
+:flag_completions_without_arg:
+  name: invalid
+  help: flag must have an arg when using completions
+  flags:
+  - long: --target
+    completions: [<dir>]
+
+:flag_allowed_and_completions:
+  name: invalid
+  help: flag with both allowed and completions
+  flags:
+  - long: --file
+    allowed: [one, two]
+    completions: [<file>]
+
 :root_alias:
   name: invalid
   help: root cannot have alias