add specs

Author: DannyBen

lib/completely/commands/install.rb

@@ -3,7 +3,21 @@
 module Completely
   module Commands
     class Install < Base
-      help 'Install a bash completion script'
+      TARGETS = %W[
+        /usr/share/bash-completion/completions
+        /usr/local/etc/bash_completion.d
+        #{Dir.home}/.bash_completion.d
+      ]
+
+      summary 'Install a bash completion script'
+
+      help <<~HELP
+        This command will copy the specified file to one of the following directories:
+
+        #{TARGETS.map { |c| "  - #{c}" }.join "\n"}
+
+        The target filename will be the program name, and sudo will be used if necessary.
+      HELP
 
       usage 'completely install PROGRAM [SCRIPT_PATH --force]'
       usage 'completely install (-h|--help)'
@@ -32,11 +46,15 @@ def bounce
           raise "Cannot find script: m`#{script_path}`"
         end
 
-        if File.exist?(target_path) && !args['--force']
+        if target_exist? && !args['--force']
           raise "File exists: m`#{target_path}`\nUse nb`--force` to overwrite"
         end
       end
 
+      def target_exist?
+        File.exist? target_path
+      end
+
       def command
         result = root? ? [] : %w[sudo]
         result + %W[cp #{script_path} #{target_path}]
@@ -59,13 +77,8 @@ def completions_path
       end
 
       def completions_path!
-        candidates = %w[
-          /usr/share/bash-completion/completions
-          /usr/local/etc/bash_completion.d
-        ]
-
-        candidates.each do |candidate|
-          return candidate if Dir.exist? candidate
+        TARGETS.each do |tarnet|
+          return tarnet if Dir.exist? tarnet
         end
 
         nil

spec/approvals/cli/install/help

@@ -0,0 +1,28 @@
+Install a bash completion script
+
+This command will copy the specified file to one of the following directories:
+
+  - /usr/share/bash-completion/completions
+  - /usr/local/etc/bash_completion.d
+  - /home/vagrant/.bash_completion.d
+
+The target filename will be the program name, and sudo will be used if
+necessary.
+
+Usage:
+  completely install PROGRAM [SCRIPT_PATH --force]
+  completely install (-h|--help)
+
+Options:
+  -f --force
+    Overwrite target file if it exists
+
+  -h --help
+    Show this help
+
+Parameters:
+  PROGRAM
+    Name of the program the completions are for.
+
+  SCRIPT_PATH
+    Path to the source bash script [default: completely.bash].

spec/approvals/cli/install/install-default

@@ -0,0 +1 @@
+Saved /usr/share/bash-completion/completions/completely-test

spec/approvals/cli/install/install-specified

@@ -0,0 +1 @@
+Saved /usr/share/bash-completion/completions/completely-test

spec/approvals/cli/install/missing-script

@@ -0,0 +1 @@
+#<RuntimeError: Cannot find script: m`completely.bash`>

spec/approvals/cli/install/no-args

@@ -0,0 +1,3 @@
+Usage:
+  completely install PROGRAM [SCRIPT_PATH --force]
+  completely install (-h|--help)

spec/approvals/cli/install/no-completion-targets

@@ -0,0 +1 @@
+#<RuntimeError: Cannot determine system completions directory>

spec/approvals/cli/install/target-exists

@@ -0,0 +1,2 @@
+#<RuntimeError: File exists: m`/usr/share/bash-completion/completions/completely-test`
+Use nb`--force` to overwrite>

spec/completely/commands/install_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+describe Commands::Install do
+  subject { described_class.new }
+
+  context 'with --help' do
+    it 'shows long usage' do
+      expect { subject.execute %w[install --help] }.to output_approval('cli/install/help')
+    end
+  end
+
+  context 'without arguments' do
+    it 'shows short usage' do
+      expect { subject.execute %w[install] }.to output_approval('cli/install/no-args')
+    end
+  end
+
+  context 'with only the program name argument' do
+    context 'when the default script is not found' do
+      it 'raises an error' do
+        expect { subject.execute %w[install completely-test] }.to raise_approval('cli/install/missing-script')
+      end
+    end
+
+    context 'when the default script is found' do
+      let(:expected_args) {
+        %w[
+          sudo
+          cp
+          completely.bash
+          /usr/share/bash-completion/completions/completely-test
+        ]
+      }
+
+      before do
+        reset_tmp_dir
+        File.write 'spec/tmp/completely.bash', 'not-important'
+      end
+
+      it 'copies the script' do
+        Dir.chdir 'spec/tmp' do
+          expect(subject).to receive(:system).with(*expected_args).and_return true
+          expect { subject.execute %W[install completely-test] }.to output_approval('cli/install/install-default')
+        end
+      end
+    end
+  end
+
+  context 'with the program name argument and a script argument' do
+    let(:expected_args) {
+      %w[
+        sudo
+        cp
+        README.md
+        /usr/share/bash-completion/completions/completely-test
+      ]
+    }
+
+    it 'copies the script' do
+      expect(subject).to receive(:system).with(*expected_args).and_return true
+      expect { subject.execute %W[install completely-test README.md] }.to output_approval('cli/install/install-specified')
+    end
+  end
+
+  context 'when none of the target directories is found' do
+    it 'raises an error' do
+      expect(subject).to receive(:completions_path).and_return nil
+      expect { subject.execute %W[install completely-test README.md] }.to raise_approval('cli/install/no-completion-targets')
+    end
+  end
+
+  context 'when the target file exists' do
+    it 'raises an error' do
+      expect(subject).to receive(:target_exist?).and_return true
+      expect { subject.execute %W[install completely-test README.md] }.to raise_approval('cli/install/target-exists')
+    end
+  end
+end