rubocop

Author: DannyBen

lib/completely/commands/base.rb

@@ -36,7 +36,7 @@ def script
 
       def completions
         @completions ||= if config_path == '-'
-          raise Error, "Nothing is piped on stdin" if $stdin.tty?
+          raise Error, 'Nothing is piped on stdin' if $stdin.tty?
 
           Completions.read $stdin, function_name: args['--function']
         else

lib/completely/commands/generate.rb

@@ -15,16 +15,16 @@ class Generate < Base
       param 'CONFIG_PATH', <<~USAGE
         Path to the YAML configuration file [default: completely.yaml].
         Use '-' to read from stdin.
-        
+
         Can also be set by an environment variable.
       USAGE
 
       param 'OUTPUT_PATH', <<~USAGE
         Path to the output bash script.
         Use '-' for stdout.
-        
+
         When not provided, the name of the input file will be used with a .bash extension, unless the input is stdin - in this case the default will be to output to stdout.
-        
+
         Can also be set by an environment variable.
       USAGE
 

lib/completely/completions.rb

@@ -29,7 +29,7 @@ def patterns
     end
 
     def valid?
-      pattern_prefixes.uniq.count == 1
+      pattern_prefixes.uniq.one?
     end
 
     def script

spec/completely/commands/generate_spec.rb

@@ -89,8 +89,7 @@
 
   context 'with stdin and stdout' do
     it 'reads config from stdin and writes to stdout' do
-      allow($stdin).to receive(:tty?).and_return false
-      allow($stdin).to receive(:read).and_return File.read('completely.yaml')
+      allow($stdin).to receive_messages(tty?: false, read: File.read('completely.yaml'))
 
       expect { subject.execute %w[generate -] }
         .to output_approval('cli/generated-script')
@@ -101,8 +100,7 @@
     let(:outfile) { 'spec/tmp/stdin-to-file.bash' }
 
     it 'reads config from stdin and writes to file' do
-      allow($stdin).to receive(:tty?).and_return false
-      allow($stdin).to receive(:read).and_return File.read('completely.yaml')
+      allow($stdin).to receive_messages(tty?: false, read: File.read('completely.yaml'))
 
       expect { subject.execute %W[generate - #{outfile}] }.to output_approval('cli/generate/custom-path-stdin')
       expect(File.read outfile).to match_approval('cli/generated-script')