Remove use of prim_file:list_dir/2

The use of it was a hack of some sort - which is not presently understood.  It is no longer valid due to erlang/otp@ebbd26e removing the export.

It is assumed that list_dir was originally added to avoid problems no solved via dirty NIF scheduling for file I/O

Author: martinsumner

.gitignore

@@ -12,3 +12,4 @@ _build/*
 /.eqc-info
 /current_counterexample.eqc
 .pulse
+rebar.lock

.travis.yml

@@ -1,9 +1,8 @@
 language: erlang
 otp_release:
   - 20.3.8
+  - 21.3
+  - 22.1
 script:
   - chmod u+x rebar3
-  - ./rebar3 do upgrade, compile, dialyzer, xref, eunit
-notifications:
-  slack:
-    secure: SE0EMU9HenZlLBuNg7l6WLMxJPkfyAEGgodvAqMEuQmICtrh1nV019D/A8ykejYYPPsJafWVOfypOSDrSHCndzXvEZvU8l45nJ6XLdUdrDYEmvcSqN3EqmVSsuf9H3g99bvKygXaY27MkTS5ixLil7PzybG+YpwMnQGcQxYo5Eg=
+  - ./rebar3 do upgrade, compile, xref, dialyzer, eunit

rebar.config

@@ -1,5 +1,6 @@
 {erl_opts, [debug_info, warn_untyped_record,
-            {platform_define, "^[0-9]+", namespaced_types}]}.
+            {platform_define, "^[0-9]+", namespaced_types},
+            {platform_define, "^[2-9][1-9]\..*", dirty_file_nif}]}.
 {port_specs, [{"priv/bitcask.so", ["c_src/*.c"]}]}.
 
 {port_env,

src/bitcask.erl

@@ -3073,6 +3073,11 @@ corrupt_file(Path, Offset, Data) ->
 
 % Verify that if the cached efile port goes away, we can recover
 % and not get stuck opening casks
+
+-ifdef(dirty_file_nif).
+efile_error_test() ->
+    ok.
+-else.
 efile_error_test() ->
     Dir = setup_testfolder("bc.efile.error"),
     B = bitcask:open(Dir, [read_write]),
@@ -3089,6 +3094,8 @@ efile_error_test() ->
         B2 when is_reference(B2) ->
             ok = bitcask:close(B2)
     end.
+-endif.
+
 
 %% About leak_t0():
 %%

src/bitcask_fileops.erl

@@ -837,6 +837,10 @@ ensure_dir(F) ->
             end
     end.
 
+-ifdef(dirty_file_nif).
+list_dir(Dir) ->
+    file:list_dir(Dir).
+-else.
 list_dir(Dir) ->
     list_dir(Dir, 1).
 
@@ -881,3 +885,4 @@ prim_file_drv_open(Driver, Portopts) ->
             {error, Reason}
     end.
 
+-endif.