Skip to content

Commit a3671c9

Browse files
author
Brett Hazen
committed
Fix unit tests for rt_config
1 parent 8704610 commit a3671c9

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

src/rt_config.erl

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,13 @@
5252
-define(PREVIOUS_VERSION_KEY, previous).
5353
-define(LEGACY_VERSION_KEY, legacy).
5454
-define(DEFAULT_VERSION, head).
55+
-define(DEFAULT_ACTUAL_VERSION, {riak_ee, "2.1.0"}).
56+
-define(DEFAULT_ACTUAL_VERSION_TAG, "riak_ee-2.1.0").
5557
-define(UPGRADE_KEY, upgrade_paths).
56-
-define(PREVIOUS_VERSION, "1.4.12").
57-
-define(LEGACY_VERSION, "1.3.4").
58+
-define(PREVIOUS_VERSION, {riak_ee, "1.4.12"}).
59+
-define(PREVIOUS_VERSION_TAG, "riak_ee-1.4.12").
60+
-define(LEGACY_VERSION, {riak_ee, "1.3.4"}).
61+
-define(LEGACY_VERSION_TAG, "riak_ee-1.3.4").
5862
-define(CONTINUE_ON_FAIL_KEY, continue_on_fail).
5963
-define(DEFAULT_CONTINUE_ON_FAIL, false).
6064

@@ -317,17 +321,15 @@ get_rt_max_wait_time_default_test() ->
317321
?assertEqual(ExpectedWaitTime, get(rt_max_wait_time, DefaultWaitTime)).
318322

319323
get_version_path_test() ->
320-
clear(?DEFAULT_VERSION_KEY),
321-
clear(?PREVIOUS_VERSION_KEY),
322-
clear(?LEGACY_VERSION_KEY),
323-
324-
set(?DEFAULT_VERSION_KEY, ?DEFAULT_VERSION),
325-
set(?PREVIOUS_VERSION_KEY, ?PREVIOUS_VERSION),
326-
set(?LEGACY_VERSION_KEY, ?LEGACY_VERSION),
327-
328-
?assertEqual(version_to_tag(?DEFAULT_VERSION_KEY), ?DEFAULT_VERSION),
329-
?assertEqual(version_to_tag(?PREVIOUS_VERSION_KEY), ?PREVIOUS_VERSION),
330-
?assertEqual(version_to_tag(?LEGACY_VERSION_KEY), ?LEGACY_VERSION).
324+
Versions = [{?DEFAULT_VERSION_KEY, ?DEFAULT_VERSION},
325+
{?DEFAULT_VERSION, ?DEFAULT_ACTUAL_VERSION},
326+
{?PREVIOUS_VERSION_KEY, ?PREVIOUS_VERSION},
327+
{?LEGACY_VERSION_KEY, ?LEGACY_VERSION}],
328+
ok = rt_config:set(?VERSION_KEY, Versions),
329+
330+
?assertEqual(version_to_tag(?DEFAULT_VERSION_KEY), ?DEFAULT_ACTUAL_VERSION_TAG),
331+
?assertEqual(version_to_tag(?PREVIOUS_VERSION_KEY), ?PREVIOUS_VERSION_TAG),
332+
?assertEqual(version_to_tag(?LEGACY_VERSION_KEY), ?LEGACY_VERSION_TAG).
331333

332334
get_continue_on_fail_test() ->
333335
clear(?CONTINUE_ON_FAIL_KEY),

0 commit comments

Comments
 (0)