CLN: Use ruff to improve code quality

Author: bashtage

linearmodels/__init__.py

@@ -35,6 +35,7 @@
 from __future__ import annotations
 
 import os
+import sys
 
 from ._version import version as __version__, version_tuple
 from .asset_pricing.model import (
@@ -92,10 +93,9 @@ def test(
     append: bool = True,
     location: str = "",
 ) -> int:
-    import sys
 
     try:
-        import pytest
+        import pytest  # noqa: PLC0415
     except ImportError as exc:  # pragma: no cover
         raise ImportError("Need pytest to run tests") from exc
 

linearmodels/asset_pricing/model.py

@@ -1097,8 +1097,9 @@ def fit(
         r2 = 1.0 - residual_ss / total_ss
         param_names = []
         for portfolio in self.portfolios.cols:
-            for factor in self.factors.cols:
-                param_names.append(f"beta-{portfolio}-{factor}")
+            param_names.extend(
+                [f"beta-{portfolio}-{factor}" for factor in self.factors.cols]
+            )
         if not excess_returns:
             param_names.append("lambda-risk_free")
         param_names.extend([f"lambda-{f}" for f in self.factors.cols])

linearmodels/datasets/birthweight/__init__.py

@@ -1,5 +1,7 @@
 from pandas import DataFrame
 
+from linearmodels import datasets
+
 DESCR = """
 J. Mullahy (1997), "Instrumental-Variable Estimation of Count Data Models:
 Applications to Models of Cigarette Smoking Behavior," Review of Economics
@@ -23,6 +25,5 @@
 
 
 def load() -> DataFrame:
-    from linearmodels import datasets
 
     return datasets.load(__file__, "birthweight.csv.bz2")

linearmodels/datasets/card/__init__.py

@@ -1,5 +1,7 @@
 from pandas import DataFrame
 
+from linearmodels import datasets
+
 DESCR = """
 D. Card (1995), "Using Geographic Variation in College Proximity to Estimate
 the Return to Schooling," in Aspects of Labour Market Behavior:  Essays in
@@ -44,6 +46,5 @@
 
 
 def load() -> DataFrame:
-    from linearmodels import datasets
 
     return datasets.load(__file__, "card.csv.bz2")

linearmodels/datasets/fertility/__init__.py

@@ -1,5 +1,7 @@
 from pandas import DataFrame
 
+from linearmodels import datasets
+
 DESCR = """
 W. Sander, "The Effect of Women's Schooling on Fertility," Economics Letters
 40, 229-233.
@@ -35,6 +37,5 @@
 
 
 def load() -> DataFrame:
-    from linearmodels import datasets
 
     return datasets.load(__file__, "fertility.csv.bz2")

linearmodels/datasets/french/__init__.py

@@ -1,5 +1,7 @@
 from pandas import DataFrame, to_datetime
 
+from linearmodels import datasets
+
 DESCR = """
 Data from Ken French's data library
 http://mba.tuck.dartmouth.edu/pages/faculty/ken.french/data_library.html
@@ -44,7 +46,6 @@
 
 
 def load() -> DataFrame:
-    from linearmodels import datasets
 
     data = datasets.load(__file__, "french.csv.bz2")
     data["dates"] = to_datetime(data.dates)

linearmodels/datasets/fringe/__init__.py

@@ -1,5 +1,7 @@
 from pandas import DataFrame
 
+from linearmodels import datasets
+
 # noinspection SpellCheckingInspection,SpellCheckingInspection
 DESCR = """
 F. Vella (1993), "A Simple Estimator for Simultaneous Models with Censored
@@ -48,6 +50,5 @@
 
 
 def load() -> DataFrame:
-    from linearmodels import datasets
 
     return datasets.load(__file__, "fringe.csv.bz2")

linearmodels/datasets/jobtraining/__init__.py

@@ -1,5 +1,7 @@
 from pandas import DataFrame
 
+from linearmodels import datasets
+
 DESCR = """
 H. Holzer, R. Block, M. Cheatham, and J. Knott (1993), "Are Training Subsidies
 Effective? The Michigan Experience," Industrial and Labor Relations Review 46,
@@ -39,6 +41,5 @@
 
 
 def load() -> DataFrame:
-    from linearmodels import datasets
 
     return datasets.load(__file__, "jobtraining.csv.bz2")

linearmodels/datasets/meps/__init__.py

@@ -1,5 +1,7 @@
 from pandas import DataFrame
 
+from linearmodels import datasets
+
 DESCR = """
 age               Age
 age2              Age-squared
@@ -34,6 +36,5 @@
 
 
 def load() -> DataFrame:
-    from linearmodels import datasets
 
     return datasets.load(__file__, "meps.csv.bz2")

linearmodels/datasets/mroz/__init__.py

@@ -1,5 +1,7 @@
 from pandas import DataFrame
 
+from linearmodels import datasets
+
 DESCR = """
 T.A. Mroz (1987), "The Sensitivity of an Empirical Model of Married Women's
 Hours of Work to Economic and Statistical Assumptions," Econometrica 55,
@@ -31,6 +33,5 @@
 
 
 def load() -> DataFrame:
-    from linearmodels import datasets
 
     return datasets.load(__file__, "mroz.csv.bz2")