TST: Skip fomrulas that cannot pass

Omit escaped formulas that cannot pass for now

Author: bashtage

linearmodels/panel/model.py

@@ -1830,7 +1830,7 @@ def fit(
             if not weighted:
                 y, x, ybar = self._fast_path(low_memory=low_memory)
                 y_effects = np.array([0.0])
-                x_effects = np.zeros(x.shape[1])
+                x_effects = np.zeros(x.shape)
             else:
                 y, x, ybar, y_effects, x_effects = self._weighted_fast_path(
                     low_memory=low_memory

linearmodels/tests/panel/test_panel_ols.py

@@ -1344,7 +1344,7 @@ def test_singleton_removal_other_effects(data):
 def test_singleton_removal_mixed(singleton_data, other_effects):
     if other_effects == 1:
         other_effects = PanelData(singleton_data.c).dataframe.iloc[:, [0]]
-    elif other_effects == 2:
+    else:
         other_effects = singleton_data.c
     mod = PanelOLS(singleton_data.y, singleton_data.x, other_effects=other_effects)
     res_keep = mod.fit(use_lsmr=True)
@@ -1534,7 +1534,7 @@ def test_entity_into():
     assert ti["min"] == 16
 
 
-@pytest.mark.parametrize("path", ["use_lsdv", "low_memory"])
+@pytest.mark.parametrize("path", ["use_lsdv", "low_memory", ""])
 def test_absorbed_with_weights(path):
     data = wage_panel.load().copy()
     year = pd.Categorical(data.year)

linearmodels/tests/system/test_formulas.py

@@ -50,6 +50,15 @@
     key += " : " + str(m[0].__name__)
     ids.append(key)
 
+escape_fmlas = fmlas[:2] + fmlas[3:]
+escape_params = list(product(escape_fmlas, models))
+
+escape_ids = []
+for f, m in escape_params:
+    key = "--".join([value for value in f.values()])
+    key += " : " + str(m[0].__name__)
+    escape_ids.append(key)
+
 
 def sigmoid(v):
     return np.exp(v) / (1 + np.exp(v))
@@ -62,6 +71,13 @@ def config(request):
     return fmla, model, interface
 
 
+@pytest.fixture(scope="module", params=escape_params, ids=escape_ids)
+def escape_config(request):
+    fmla, model_interace = request.param
+    model, interface = model_interace
+    return fmla, model, interface
+
+
 def test_formula(config):
     fmla, model, interface = config
     for key in fmla:
@@ -182,8 +198,8 @@ def test_parser(config):
                 assert_frame_equal(eq1[key], eq2[key])
 
 
-def test_formula_escaped(config):
-    fmla, model, interface = config
+def test_formula_escaped(escape_config):
+    fmla, model, interface = escape_config
     for key in fmla:
         if "[" in fmla[key] and model not in (IVSystemGMM, IV3SLS):
             return
@@ -205,6 +221,7 @@ def fix_formula(fmla):
     escaped_fmla = fix_formula(fmla)
     data = joined.copy()
     data.columns = cols
+
     mod = model.from_formula(escaped_fmla, data)
     pmod = pickle.loads(pickle.dumps(mod))
     mod_fmla = interface(escaped_fmla, data)