Conversation
…s during move operations This fixes issue #155 where moving entities with null permalinks (from database migration) would cause validation errors when creating EntityResponse objects. Changes: - Modified move_entity method to generate permalinks when old_permalink is None - Added comprehensive test to verify fix works correctly - Test confirms EntityResponse validation succeeds after move operation The fix ensures backward compatibility with the update_permalinks_on_move setting while preventing validation errors for migrated entities with null permalinks. Co-authored-by: Paul Hernandez <phernandez@users.noreply.github.com>
Member
|
|
groksrc
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155
This PR resolves the validation error that occurs when moving entities with null permalinks from the database migration.
Changes
move_entitymethod to generate permalinks whenold_permalink is NoneBackward Compatibility
The fix maintains full backward compatibility with the
update_permalinks_on_movesetting while preventing validation errors for migrated entities.Generated with Claude Code