Merge pull request #35 from basics/feature/git-action-feature

StephanGerbeth · web-flow · commit e487590dfab8 · 2024-09-17T08:51:35.000+02:00
Feature/git action feature
diff --git a/.github/workflows/beta.yml b/.github/workflows/beta.yml
@@ -13,19 +13,21 @@ jobs:
   install:
     if: "!contains(github.event.head_commit.message, 'skip ci')"
     name: Install
-    runs-on: ${{ matrix.os }}
-
     strategy:
       matrix:
         os: [ubuntu-latest]
         node: [20]
 
+    runs-on: ${{ matrix.os }}
+
     steps:
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
+
       - name: Checkout Repo
         uses: actions/checkout@v4
+
       - name: cache node_modules
         uses: actions/cache@v4
         id: cache
@@ -53,25 +55,28 @@ jobs:
   semantic-version:
     name: Semantic Release
     needs: install
-    runs-on: ${{ matrix.os }}
-
     strategy:
       matrix:
         os: [ubuntu-latest]
         node: [20]
 
+    runs-on: ${{ matrix.os }}
+
     steps:
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
+
       - name: Checkout Repo
         uses: actions/checkout@v4
+
       - name: cache node_modules
         uses: actions/cache@v4
         id: cache
         with:
           path: node_modules
           key: ${{ matrix.os }}-node-v${{ matrix.node }}-deps-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
+
       - name: Versioning
         env:
           GH_TOKEN: ${{ secrets.GH_TOKEN }}
@@ -83,24 +88,24 @@ jobs:
   sonarcloud:
     name: SonarCloud
     needs: semantic-version
-    runs-on: ${{ matrix.os }}
-
     strategy:
       matrix:
         os: [ubuntu-latest]
         node: [20]
 
+    runs-on: ${{ matrix.os }}
+
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+
       - name: Download vitest code coverage results
         uses: actions/download-artifact@v4
         with:
           name: vitest-code-coverage-report
           path: ./coverage/
-      - name: check
-        run: cd coverage && find .
+
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master
         env:
diff --git a/.github/workflows/feature.yml b/.github/workflows/feature.yml
@@ -0,0 +1,80 @@
+name: Feature
+
+on:
+  push:
+    branches:
+      - 'feature/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  install:
+    if: "!contains(github.event.head_commit.message, 'skip ci')"
+    name: Install
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+        node: [20]
+
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node }}
+
+      - name: Checkout Repo
+        uses: actions/checkout@v4
+
+      - name: cache node_modules
+        uses: actions/cache@v4
+        id: cache
+        with:
+          path: |
+            node_modules
+          key: ${{ matrix.os }}-node-v${{ matrix.node }}-deps-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
+
+      - name: Install Dependencies
+        if: steps.cache.outputs.cache-hit != 'true'
+        run: npm ci
+
+      - name: Lint
+        run: npm run lint
+
+      - name: Vitest - Test & Coverage
+        run: npm run coverage
+
+      - name: Archive vitest code coverage results
+        uses: actions/upload-artifact@v4
+        with:
+          name: vitest-code-coverage-report
+          path: ./coverage/
+
+  sonarcloud:
+    name: SonarCloud
+    needs: install
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+        node: [20]
+
+    runs-on: ${{ matrix.os }}
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+
+      - name: Download vitest code coverage results
+        uses: actions/download-artifact@v4
+        with:
+          name: vitest-code-coverage-report
+          path: ./coverage/
+
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -13,19 +13,21 @@ jobs:
   install:
     if: "!contains(github.event.head_commit.message, 'skip ci')"
     name: Install
-    runs-on: ${{ matrix.os }}
-
     strategy:
       matrix:
         os: [ubuntu-latest]
         node: [20]
 
+    runs-on: ${{ matrix.os }}
+
     steps:
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
+
       - name: Checkout Repo
         uses: actions/checkout@v4
+
       - name: cache node_modules
         uses: actions/cache@v4
         id: cache
@@ -53,25 +55,28 @@ jobs:
   semantic-version:
     name: Semantic Release
     needs: install
-    runs-on: ${{ matrix.os }}
-
     strategy:
       matrix:
         os: [ubuntu-latest]
         node: [20]
 
+    runs-on: ${{ matrix.os }}
+
     steps:
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
+
       - name: Checkout Repo
         uses: actions/checkout@v4
+
       - name: cache node_modules
         uses: actions/cache@v4
         id: cache
         with:
           path: node_modules
           key: ${{ matrix.os }}-node-v${{ matrix.node }}-deps-${{ hashFiles(format('{0}{1}', github.workspace, '/package-lock.json')) }}
+
       - name: Versioning
         env:
           GH_TOKEN: ${{ secrets.GH_TOKEN }}
@@ -83,24 +88,24 @@ jobs:
   sonarcloud:
     name: SonarCloud
     needs: semantic-version
-    runs-on: ${{ matrix.os }}
-
     strategy:
       matrix:
         os: [ubuntu-latest]
         node: [20]
 
+    runs-on: ${{ matrix.os }}
+
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+
       - name: Download vitest code coverage results
         uses: actions/download-artifact@v4
         with:
           name: vitest-code-coverage-report
           path: ./coverage/
-      - name: check
-        run: cd coverage && find .
+
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master
         env:
diff --git a/packages/observables/CHANGELOG.md b/packages/observables/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Project Changelog
 
+# [@rxjs-collection/observables-v1.0.1](https://github.com/basics/rxjs-collection/compare/@rxjs-collection/observables-v1.0.0...@rxjs-collection/observables-v1.0.1) (2024-09-16)
+
+
+### Bug Fixes
+
+* **observables:** removed two warnings ([52303ad](https://github.com/basics/rxjs-collection/commit/52303ad41290b6d06d74a2f172f42edb3176c8fa))
+
 # [@rxjs-collection/observables-v1.0.1-beta.1](https://github.com/basics/rxjs-collection/compare/@rxjs-collection/observables-v1.0.0...@rxjs-collection/observables-v1.0.1-beta.1) (2024-09-16)
 
 
diff --git a/packages/observables/package.json b/packages/observables/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@rxjs-collection/observables",
-  "version": "1.0.1-beta.1",
+  "version": "1.0.1",
   "description": "rxjs observables",
   "license": "MIT",
   "contributors": [

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@rxjs-collection/observables",`
`3`		`- "version": "1.0.1-beta.1",`
	`3`	`+ "version": "1.0.1",`
`4`	`4`	`"description": "rxjs observables",`
`5`	`5`	`"license": "MIT",`
`6`	`6`	`"contributors": [`