Update allowed Python dunder method set (#944)

Fixes #943

Author: chrisrink10

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
  * Updated dozens of type annotations in the compiler to satisfy MyPy 1.11 (#910)
  * Update the `StreamReader` methods to stop using the term "token" to refer to individual UTF-8 characters (#915)
+ * Update the list of Python dunder methods which are allowed to be implemented for all `deftype*` and `reify*` types (#943)
 
 ### Fixed
  * Fix a bug where `.` characters were not allowed in keyword names (#899)

src/basilisp/lang/util.py

@@ -86,91 +86,113 @@ def is_abstract(tp: Type) -> bool:
     )
 
 
-# Trimmed list of __dunder__ methods generated by using this command:
+# Trimmed list of __dunder__ methods generated by using this shell command:
 #
-#     find "$(poetry env info -p)/lib/python3.6" \
-#          -name '*.py' \
-#          -exec egrep \
-#          -oh '__[A-Za-z_][A-Za-z_0-9]*__' '{}' \; \
-#          | sort | uniq
+#     curl https://raw.githubusercontent.com/python/cpython/main/Doc/reference/datamodel.rst \
+#       | egrep -oh '__[a-z_][A-Za-z_0-9]*__' \
+#       | sort \
+#       | uniq
+#
+# Running the above command will yield a list of dunders from the Python 'Data Model'
+# documentation page, but many of those matches will be false positives. Many hits
+# are object properties (such as __doc__ and __name__) and others are not dunders
+# at all (such as the unfortunately named __future__ module).
+#
+# Unfortunately we can't introspect this list from Python itself, so it's going to be
+# a moving target as the data model changes over time.
+#
+# Note that some Python standard library modules and packages define their own dunder
+# methods which are not documented in the data model documentation which are included
+# in separate sets below.
 OBJECT_DUNDER_METHODS = frozenset(
     {
         "__abs__",
         "__add__",
         "__aenter__",
         "__aexit__",
         "__aiter__",
+        "__and__",
+        "__anext__",
         "__await__",
+        "__bool__",
+        "__buffer__",
         "__bytes__",
         "__call__",
+        "__ceil__",
+        "__class_getitem__",
         "__complex__",
         "__contains__",
         "__del__",
         "__delattr__",
+        "__delete__",
         "__delitem__",
-        "__delslice__",
         "__dict__",
         "__dir__",
-        "__div__",
         "__divmod__",
         "__enter__",
         "__eq__",
         "__exit__",
         "__float__",
+        "__floor__",
         "__floordiv__",
+        "__format__",
         "__ge__",
+        "__get__",
         "__getattr__",
         "__getattribute__",
         "__getitem__",
-        "__getslice__",
-        "__getstate__",
         "__gt__",
         "__hash__",
         "__iadd__",
         "__iand__",
-        "__idiv__",
         "__ifloordiv__",
         "__ilshift__",
         "__imatmul__",
         "__imod__",
         "__imul__",
+        "__index__",
         "__init__",
+        "__init_subclass__",
         "__instancecheck__",
         "__int__",
         "__invert__",
         "__ior__",
         "__ipow__",
+        "__irshift__",
         "__isub__",
         "__iter__",
         "__itruediv__",
         "__ixor__",
         "__le__",
         "__len__",
+        "__length_hint__",
         "__lshift__",
+        "__lt__",
+        "__match_args__",
         "__matmul__",
+        "__missing__",
         "__mod__",
+        "__mro_entries__",
         "__mul__",
         "__ne__",
         "__neg__",
-        "__next__",
         "__new__",
-        "__not__",
+        "__next__",
+        "__or__",
         "__pos__",
         "__pow__",
+        "__prepare__",
         "__radd__",
         "__rand__",
-        "__rcmp__",
-        "__rdiv__",
         "__rdivmod__",
-        "__reduce__",
-        "__reduce_ex__",
+        "__release_buffer__",
         "__repr__",
+        "__reversed__",
         "__rfloordiv__",
         "__rlshift__",
         "__rmatmul__",
         "__rmod__",
         "__rmul__",
-        "__rne__",
         "__ror__",
         "__round__",
         "__rpow__",
@@ -179,17 +201,32 @@ def is_abstract(tp: Type) -> bool:
         "__rsub__",
         "__rtruediv__",
         "__rxor__",
+        "__set__",
+        "__set_name__",
         "__setattr__",
         "__setitem__",
-        "__setslice__",
-        "__setstate__",
+        "__sizeof__",
+        "__slots__",
         "__str__",
         "__sub__",
         "__subclasscheck__",
-        "__subclasshook__",
         "__truediv__",
+        "__trunc__",
         "__xor__",
     }
+    |
+    # Support for ABCs
+    {"__subclasshook__"}
+    |
+    # Support for pickling
+    {
+        "__getnewargs_ex__",
+        "__getnewargs__",
+        "__getstate__",
+        "__reduce__",
+        "__reduce_ex__",
+        "__setstate__",
+    }
 )