Properly escape string output at the REPL (#902)

Fixes #894

Author: chrisrink10

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### Fixed
  * Fix a bug where `.` characters were not allowed in keyword names (#899)
+ * Fix a bug where nested quotation marks were not escaped properly by various print functions and at the REPL (#894)
 
 ## [v0.1.0b2]
 ### Added

src/basilisp/lang/obj.py

@@ -204,8 +204,9 @@ def _lrepr_str(
     if human_readable:
         return o
     if print_readably is None or print_readably is False:
-        return f'"{o}"'
-    return f'"{o.encode("unicode_escape").decode("utf-8")}"'
+        return o
+    escaped = o.encode("unicode_escape").replace(b'"', rb"\"").decode("utf-8")
+    return f'"{escaped}"'
 
 
 @lrepr.register(list)

tests/basilisp/lrepr_test.py

@@ -147,7 +147,7 @@ def test_print_meta(lcompile: CompileFn, s: str, code: str):
 
 
 def test_print_readably(lcompile: CompileFn):
-    assert '"Hello\nworld!"' == lcompile(
+    assert "Hello\nworld!" == lcompile(
         '(binding [*print-readably* false] (pr-str "Hello\\nworld!"))'
     )
 
@@ -169,6 +169,7 @@ def test_print_readably(lcompile: CompileFn):
         ("##-Inf", "(pr-str ##-Inf)"),
         ('"hi"', '(pr-str "hi")'),
         ('"Hello\\nworld!"', '(pr-str "Hello\nworld!")'),
+        (r'"\"Hello world!\""', r'(pr-str "\"Hello world!\"")'),
         (
             '#uuid "81f35603-0408-4b3d-bbc0-462e3702747f"',
             '(pr-str #uuid "81f35603-0408-4b3d-bbc0-462e3702747f")',
@@ -214,6 +215,7 @@ def test_lrepr(lcompile: CompileFn, repr: str, code: str):
         (-float("inf"), "(read-string (pr-str ##-Inf))"),
         ("hi", '(read-string (pr-str "hi"))'),
         ("Hello\nworld!", '(read-string (pr-str "Hello\nworld!"))'),
+        ('"Hello world!"', r'(read-string (pr-str "\"Hello world!\""))'),
         (b"", '(read-string (pr-str #b ""))'),
         (
             b"\x7fELF\x01\x01\x01\x00",
@@ -267,6 +269,7 @@ def test_lrepr_round_trip_special_cases(lcompile: CompileFn):
         ("##-Inf", "(print-str ##-Inf)"),
         ("hi", '(print-str "hi")'),
         ("Hello\nworld!", '(print-str "Hello\nworld!")'),
+        ('"Hello world!"', r'(print-str "\"Hello world!\"")'),
         ('#b ""', '(print-str #b "")'),
         (
             r'#b "\x7fELF\x01\x01\x01\x00"',
@@ -319,6 +322,7 @@ def test_lstr(lcompile: CompileFn, s: str, code: str):
         ("##-Inf", "(str ##-Inf)"),
         ("hi", '(str "hi")'),
         ("Hello\nworld!", '(str "Hello\nworld!")'),
+        ('"Hello world!"', r'(str "\"Hello world!\"")'),
         ('#b ""', '(str #b "")'),
         (
             r'#b "\x7fELF\x01\x01\x01\x00"',