Skip to content

Commit 2f9e2a6

Browse files
authored
Disable testrunner test for pypy-3.9 which produces erroneous behvr (#970)
Hi, can you please consider follow up patch to #966 to disable a testrunner test that fails intermittently on PyPy3.9 because it produces a traceback line number which is erroneous. This doesn't appear to be an issue with Basilisp, but rather with that particular version of PyPy. I've also removed an if else block in the same which appear to me to be redundant, both if/else blocks were doing the same. I can see the test in question did not run on my circle ci run. Thanks Co-authored-by: ikappaki <[email protected]>
1 parent f1ec6b7 commit 2f9e2a6

File tree

1 file changed

+11
-21
lines changed

1 file changed

+11
-21
lines changed

tests/basilisp/testrunner_test.py

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -132,31 +132,21 @@ def test_failure_repr(self, run_result: pytest.RunResult):
132132
)
133133

134134
@pytest.mark.xfail(
135-
platform.python_implementation() == "PyPy" and sys.version_info < (3, 9),
135+
platform.python_implementation() == "PyPy" and sys.version_info < (3, 10),
136136
reason=(
137-
"PyPy 3.8 seems to fail this test, but 3.9 doesn't so it doesn't bear "
138-
"further investigation."
137+
"PyPy 3.9 fails this test because it intermittently produces an incorrect"
138+
"line number (128014) in the exception traceback, which is clearly erroneous."
139139
),
140140
)
141141
def test_error_repr(self, run_result: pytest.RunResult):
142-
if sys.version_info < (3, 11):
143-
expected = [
144-
"ERROR in (assertion-test) (test_testrunner.lpy:14)",
145-
"",
146-
"Traceback (most recent call last):",
147-
' File "*test_testrunner.lpy", line 14, in assertion_test',
148-
' (is (throw (ex-info "Uncaught exception" {})))',
149-
"basilisp.lang.exception.ExceptionInfo: Uncaught exception {}",
150-
]
151-
else:
152-
expected = [
153-
"ERROR in (assertion-test) (test_testrunner.lpy:14)",
154-
"",
155-
"Traceback (most recent call last):",
156-
' File "*test_testrunner.lpy", line 14, in assertion_test',
157-
' (is (throw (ex-info "Uncaught exception" {})))',
158-
"basilisp.lang.exception.ExceptionInfo: Uncaught exception {}",
159-
]
142+
expected = [
143+
"ERROR in (assertion-test) (test_testrunner.lpy:14)",
144+
"",
145+
"Traceback (most recent call last):",
146+
' File "*test_testrunner.lpy", line 14, in assertion_test',
147+
' (is (throw (ex-info "Uncaught exception" {})))',
148+
"basilisp.lang.exception.ExceptionInfo: Uncaught exception {}",
149+
]
160150

161151
run_result.stdout.fnmatch_lines(
162152
expected,

0 commit comments

Comments
 (0)