Support creating new INamed instances via classmethod (#886)

Additional fix for #884

Co-authored-by: Christopher Rink <[email protected]>

Author: chrisrink10

src/basilisp/lang/interfaces.py

@@ -15,7 +15,7 @@
     Union,
 )
 
-from typing_extensions import Unpack
+from typing_extensions import Self, Unpack
 
 from basilisp.lang.obj import LispObject as _LispObject
 from basilisp.lang.obj import PrintSettings, seq_lrepr
@@ -98,14 +98,11 @@ def meta(self) -> Optional["IPersistentMap"]:
         raise NotImplementedError()
 
 
-T_with_meta = TypeVar("T_with_meta", bound="IWithMeta")
-
-
 class IWithMeta(IMeta):
     __slots__ = ()
 
     @abstractmethod
-    def with_meta(self: T_with_meta, meta: "Optional[IPersistentMap]") -> T_with_meta:
+    def with_meta(self, meta: "Optional[IPersistentMap]") -> Self:
         raise NotImplementedError()
 
 
@@ -122,6 +119,12 @@ def name(self) -> str:
     def ns(self) -> Optional[str]:
         raise NotImplementedError()
 
+    @classmethod
+    @abstractmethod
+    def with_name(cls, name: str, ns: Optional[str] = None) -> Self:
+        """Create a new instance of this INamed with `name` and optional `ns`."""
+        raise NotImplementedError()
+
 
 ILispObject = _LispObject
 

src/basilisp/lang/keyword.py

@@ -35,6 +35,10 @@ def name(self) -> str:
     def ns(self) -> Optional[str]:
         return self._ns
 
+    @classmethod
+    def with_name(cls, name: str, ns: Optional[str] = None) -> "Keyword":
+        return keyword(name, ns=ns)
+
     def _lrepr(self, **kwargs: Unpack[PrintSettings]) -> str:
         if self._ns is not None:
             return f":{self._ns}/{self._name}"

src/basilisp/lang/symbol.py

@@ -47,6 +47,10 @@ def name(self) -> str:
     def ns(self) -> Optional[str]:
         return self._ns
 
+    @classmethod
+    def with_name(cls, name: str, ns: Optional[str] = None) -> "Symbol":
+        return Symbol(name, ns=ns)
+
     @property
     def meta(self) -> Optional[IPersistentMap]:
         return self._meta