More core library functions and macros (#373)

* More core library functions and macros

* Fix when-let and when-some

* Tests

* Testssss

* Additional tests

* More functions and tests

* Oops

* Bitwise functions

* Woops

* Fix seq iterators to yield to child iterators

Author: chrisrink10

src/basilisp/core/__init__.lpy

@@ -204,9 +204,9 @@ def __eq__(self, other):
 
     def __iter__(self):
         o = self
-        while o:
+        if o:
             yield o.first
-            o = o.rest
+            yield from o.rest
 
 
 class IType(ABC):

src/basilisp/lang/interfaces.py

@@ -43,6 +43,7 @@
     ISeqable,
 )
 from basilisp.lang.typing import LispNumber
+from basilisp.lang.util import munge
 from basilisp.logconfig import TRACE
 from basilisp.util import Maybe
 
@@ -827,7 +828,8 @@ def apply_kw(f, args):
     except TypeError as e:
         logger.debug("Ignored %s: %s", type(e).__name__, e)
 
-    return f(*final, **last)
+    kwargs = to_py(last, lambda kw: munge(kw.name, allow_builtins=True))
+    return f(*final, **kwargs)
 
 
 __nth_sentinel = object()
@@ -983,6 +985,11 @@ def get(m, k, default=None):
         return default
 
 
+def is_special_form(s: sym.Symbol) -> bool:
+    """Return True if s names a special form."""
+    return s in _SPECIAL_FORMS
+
+
 @functools.singledispatch
 def to_lisp(o, keywordize_keys: bool = True):
     """Recursively convert Python collections into Lisp collections."""
@@ -1240,6 +1247,7 @@ def _basilisp_fn(f):
     """Create a Basilisp function, setting meta and supplying a with_meta
     method implementation."""
     assert not hasattr(f, "meta")
+    f._basilisp_fn = True
     f.meta = None
     f.with_meta = partial(_fn_with_meta, f)
     return f

src/basilisp/lang/runtime.py

@@ -158,13 +158,13 @@ def is_realized(self):
 
     def __iter__(self):
         o = self
-        while o:
+        if o:
             first = o.first
             if isinstance(o, LazySeq):
                 if o.is_empty:
                     return
             yield first
-            o = o.rest
+            yield from o.rest
 
 
 def sequence(s: Iterable) -> ISeq[Any]:

src/basilisp/lang/seq.py

@@ -218,6 +218,54 @@
   (is (= nil (comment 1)))
   (is (= nil (comment [1 2 3]))))
 
+(deftest if-let-test
+  (is (= :a (if-let [a :a] a :b)))
+  (is (= 2 (if-let [a 1] (inc a) :b)))
+  (is (= :b (if-let [a nil] a :b)))
+  (is (= :b (if-let [a false] a :b)))
+  (is (thrown? basilisp.lang.compiler/CompilerException
+               (eval '(if-let [a nil] a a))))
+
+  ;; ExceptionInfo is thrown and wrapped in a CompilerException
+  ;; during macro expansion
+  (is (thrown? basilisp.lang.compiler/CompilerException
+               (eval '(if-let [a nil b :something] a :b)))))
+
+(deftest if-some-test
+  (is (= :a (if-some [a :a] a :b)))
+  (is (= 2 (if-some [a 1] (inc a) :b)))
+  (is (= :b (if-some [a nil] a :b)))
+  (is (= false (if-some [a false] a :b)))
+  (is (thrown? basilisp.lang.compiler/CompilerException
+               (eval '(if-some [a nil] a a))))
+
+  ;; ExceptionInfo is thrown and wrapped in a CompilerException
+  ;; during macroexpansion
+  (is (thrown? basilisp.lang.compiler/CompilerException
+               (eval '(if-some [a nil b :something] a :b)))))
+
+(deftest when-let-test
+  (is (= :a (when-let [a :a] a)))
+  (is (= 2 (when-let [a 1] (inc a))))
+  (is (nil? (when-let [a nil] a)))
+  (is (nil? (when-let [a false] a)))
+
+  ;; ExceptionInfo is thrown and wrapped in a CompilerException
+  ;; during macroexpansion
+  (is (thrown? basilisp.lang.compiler/CompilerException
+               (eval '(when-let [a nil b :something] a)))))
+
+(deftest when-some-test
+  (is (= :a (when-some [a :a] a)))
+  (is (= 2 (when-some [a 1] (inc a))))
+  (is (nil? (when-some [a nil] a)))
+  (is (= false (when-some [a false] a)))
+
+  ;; ExceptionInfo is thrown and wrapped in a CompilerException
+  ;; during macroexpansion
+  (is (thrown? basilisp.lang.compiler/CompilerException
+               (eval '(when-some [a nil b :something] a)))))
+
 (deftest ->-test
   (is (= :a (-> :a)))
   (is (= 2 (-> 1 inc)))