Allow trailing single quotes in Symbols and Keywords (#650)

* Allow trailing single quotes in Symbols and Keywords

* More parallelism for PyPy

* Add a test cuz why not

Author: chrisrink10

.circleci/config.yml

@@ -180,15 +180,15 @@ jobs:
   test-pypy-36:
     docker:
       - image: pypy:3.6-slim-buster
-    parallelism: 4
+    parallelism: 8
     steps:
       - run_pypy_tests:
           python_version: "3.6"
 
   test-pypy-37:
     docker:
       - image: pypy:3.7-slim-buster
-    parallelism: 4
+    parallelism: 8
     steps:
       - run_pypy_tests:
           python_version: "3.7"

CHANGELOG.md

@@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
  * Fixed a bug where it was impossible to use more than a single body expression in a `try` special form (#640)
  * Fixed a bug where re-`def`ing a Var (regardless of `^:redef` metadata) would not update metadata or dynamic flag (#642)
  * Fixed a bug where private Vars could be resolved from the source namespace of a public macro during macroexpansion (#648)
+ * Fixed a bug where trailing quotes were not allowed in Symbols and Keywords (#650)
 
 ### Removed
  * Removed Click as a dependency in favor of builtin `argparse` (#622, #624, #636)

src/basilisp/edn.lpy

@@ -128,7 +128,8 @@
                          :error :unexpected-char}))
               (recur name [] true))))
 
-        (re-matches ns-name-chars c)
+        (or (re-matches ns-name-chars c)
+            (and (seq name) (= c "'")))
         (do
           (.next-token reader)
           (recur ns (conj name c) has-ns))

src/basilisp/lang/reader.py

@@ -514,7 +514,7 @@ def _read_namespaced(
                 has_ns = True
                 ns = name
                 name = []
-        elif ns_name_chars.match(token):
+        elif ns_name_chars.match(token) or (name and token == "'"):
             reader.next_token()
             name.append(token)
         elif allowed_suffix is not None and token == allowed_suffix:

tests/basilisp/compiler_test.py

@@ -5368,6 +5368,17 @@ def test_private_aliased_var_does_not_resolve(
         finally:
             runtime.Namespace.remove(other_ns_name)
 
+    def test_private_var_does_not_resolve_during_macroexpansion(
+        self, lcompile: CompileFn, ns: runtime.Namespace
+    ):
+        # In a previous version of the compiler, it was possible to get access
+        # to namespace private Vars simply by referring to them from within macros
+        # from the same namespace.
+        #
+        # https://github.com/basilisp-lang/basilisp/issues/646
+        with pytest.raises(compiler.CompilerException):
+            lcompile("(let [] basilisp.core/*generated-python*)")
+
     def test_aliased_macro_symbol_resolution(
         self, lcompile: CompileFn, ns: runtime.Namespace
     ):