Skip to content

Commit 7d72f4f

Browse files
authored
Keyword str and repr are now the same (#259)
1 parent af47e84 commit 7d72f4f

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/basilisp/lang/keyword.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ def ns(self) -> Optional[str]:
2525

2626
def __str__(self):
2727
if self._ns is not None:
28-
return "{ns}/{name}".format(ns=self._ns, name=self._name)
29-
return "{name}".format(name=self._name)
28+
return ":{ns}/{name}".format(ns=self._ns, name=self._name)
29+
return ":{name}".format(name=self._name)
3030

3131
def __repr__(self):
32-
return ":{me}".format(me=str(self))
32+
return str(self)
3333

3434
def __eq__(self, other):
3535
return self is other

tests/basilisp/compiler_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -470,8 +470,8 @@ def test_recur(ns: runtime.Namespace):
470470
lcompile(code)
471471

472472
assert "a" == lcompile("(rev-str \"a\")")
473-
assert "ba" == lcompile("(rev-str \"a\" :b)")
474-
assert "3ba" == lcompile("(rev-str \"a\" :b 3)")
473+
assert ":ba" == lcompile("(rev-str \"a\" :b)")
474+
assert "3:ba" == lcompile("(rev-str \"a\" :b 3)")
475475

476476

477477
def test_recur_arity(ns: runtime.Namespace):

tests/basilisp/core_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -636,15 +636,15 @@ def test_prn_str():
636636
def test_print_str():
637637
assert '' == core.print_str()
638638
assert '' == core.print_str("")
639-
assert 'kw' == core.print_str(kw.keyword('kw'))
640-
assert 'hi there 3' == core.print_str(kw.keyword('hi'), "there", 3)
639+
assert ':kw' == core.print_str(kw.keyword('kw'))
640+
assert ':hi there 3' == core.print_str(kw.keyword('hi'), "there", 3)
641641

642642

643643
def test_println_str():
644644
assert '\n' == core.println_str()
645645
assert '\n' == core.println_str("")
646-
assert 'kw\n' == core.println_str(kw.keyword('kw'))
647-
assert 'hi there 3\n' == core.println_str(kw.keyword('hi'), "there", 3)
646+
assert ':kw\n' == core.println_str(kw.keyword('kw'))
647+
assert ':hi there 3\n' == core.println_str(kw.keyword('hi'), "there", 3)
648648

649649

650650
def test_re_find():

tests/basilisp/keyword_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ def test_keyword_name_and_ns():
2222

2323
def test_keyword_str_and_repr():
2424
kw = keyword("kw", ns="ns")
25-
assert str(kw) == "ns/kw"
25+
assert str(kw) == ":ns/kw"
2626
assert repr(kw) == ":ns/kw"
2727

2828
kw = keyword("kw", ns="some.ns")
29-
assert str(kw) == "some.ns/kw"
29+
assert str(kw) == ":some.ns/kw"
3030
assert repr(kw) == ":some.ns/kw"
3131

3232
kw = keyword("kw")
33-
assert str(kw) == "kw"
33+
assert str(kw) == ":kw"
3434
assert repr(kw) == ":kw"
3535

3636

0 commit comments

Comments
 (0)