Add Prospector linting step to CI and fix linting errors (#84)

Author: chrisrink10

.circleci/config.yml

@@ -27,6 +27,10 @@ jobs:
           name: Run Type Checks
           command: |
             make typecheck
+      - run:
+          name: Run Linter
+          command: |
+            make lint
       - run:
           name: Run Tests with Coverage
           command: |

.prospector.yaml

@@ -0,0 +1,22 @@
+output-format: text
+
+strictness: medium
+test-warnings: true
+doc-warnings: false
+
+ignore-paths:
+  - tests
+
+pep8:
+  disable:
+    - E741
+  options:
+    max-line-length: 120
+
+pylint:
+  disable:
+    - len-as-condition
+    - no-else-return
+    - protected-access
+    - unsubscriptable-object
+    - useless-import-alias

Makefile

@@ -7,7 +7,7 @@ format:
 .PHONY: lint
 lint:
 	@pipenv install --dev
-	@pipenv run python -m pyflakes .
+	@pipenv run python -m prospector > lintout.txt
 
 
 .PHONY: repl

Pipfile

@@ -5,12 +5,11 @@ name = "pypi"
 
 [dev-packages]
 coveralls = "*"
-pyflakes = "*"
-pytest = "*"
-yapf = "*"
 mypy = "*"
-autoflake = "*"
+prospector = "*"
+pytest = "*"
 pytest-cov = "*"
+yapf = "*"
 
 [packages]
 astor = "*"

Pipfile.lock

@@ -1 +0,0 @@
-