Reader will no longer resolve generated symbols in syntax-quote (#272)

Author: chrisrink10

src/basilisp/lang/reader.py

@@ -625,7 +625,7 @@ def _read_sym(ctx: ReaderContext) -> MaybeSymbol:
             return True
         elif name == 'false':
             return False
-    if ctx.is_syntax_quoted:
+    if ctx.is_syntax_quoted and not name.endswith('#'):
         return ctx.resolve(symbol.symbol(name, ns))
     return symbol.symbol(name, ns=ns)
 

tests/basilisp/reader_test.py

@@ -463,30 +463,38 @@ def complex_resolver(s: sym.Symbol) -> sym.Symbol:
 
 
 def test_syntax_quote_gensym():
-    gensym = read_str_first("`s#")
+    resolver = lambda s: sym.symbol(s.name, ns='test-ns')
+
+    gensym = read_str_first("`s#", resolver=resolver)
     assert isinstance(gensym, llist.List)
     assert gensym.first == reader._QUOTE
     genned_sym: sym.Symbol = gensym[1]
     assert genned_sym.name.startswith("s_")
 
     # Verify that identical gensym forms resolve to the same
     # symbol inside the same syntax quote expansion
-    multisym = read_str_first("`(s1# s2# s1#)")[1].rest
+    multisym = read_str_first("`(s1# s2# s1#)", resolver=resolver)[1].rest
 
     multisym1 = multisym[0][1]
     assert reader._QUOTE == multisym1[0]
     genned_sym1: sym.Symbol = multisym1[1]
+    assert genned_sym1.ns is None
     assert genned_sym1.name.startswith("s1_")
+    assert "#" not in genned_sym1.name
 
     multisym2 = multisym[1][1]
     assert reader._QUOTE == multisym2[0]
     genned_sym2: sym.Symbol = multisym2[1]
+    assert genned_sym2.ns is None
     assert genned_sym2.name.startswith("s2_")
+    assert "#" not in genned_sym2.name
 
     multisym3 = multisym[2][1]
     assert reader._QUOTE == multisym3[0]
     genned_sym3: sym.Symbol = multisym3[1]
+    assert genned_sym3.ns is None
     assert genned_sym3.name.startswith("s1_")
+    assert "#" not in genned_sym3.name
 
     assert genned_sym1 == genned_sym3
     assert genned_sym1 != genned_sym2