Clean up the test suite (#596)

 * Moved `ns` and `lcompile` fixtures into `tests/basilisp/conftest.py` so they can be used across the entire test suite. Updated all of the tests using similar fixtures to use these common fixtures instead.
    * This fixes a potential issue that can happen when Basilisp tests are run by filenames (as they are on CircleCI). If certain improperly isolated tests run before `tests/basilisp/prompt_test.py`, the current Namespace when that test is run may potentially have new `Vars` which cause the completion tests to fail with those additional Var names.
 * Moved `core_ns` fixtures into `tests/basilisp/conftest.py` so they can be used by all tests.
 * Parameterized all of the `tests/basilisp/lrepr_test.py` tests.
 * Moved remaining `basilisp.string` tests from `tests/basilisp/string_test.py` into `tests/basilisp/test_string.py` so all the tests are in one location and written in Basilisp.
 * Collapse `tests/basilisp/test_munge.py` into `tests/basilisp/test_langutil.py` (where `demunge` tests already lived alone).
 * Collapse `tests/basilisp/maybe_test.py` into `tests/basilisp/util_test.py` (where other `basilisp.util` tests already lived).

Author: chrisrink10

tests/basilisp/compiler_test.py

@@ -8,7 +8,6 @@
 import uuid
 from fractions import Fraction
 from tempfile import TemporaryDirectory
-from typing import Any, Callable, Dict, Optional
 from unittest.mock import Mock
 
 import dateutil.parser as dateparser
@@ -28,9 +27,7 @@
 from basilisp.lang.interfaces import IType, IWithMeta
 from basilisp.lang.runtime import Var
 from basilisp.lang.util import demunge
-from tests.basilisp.helpers import get_or_create_ns
-
-COMPILER_FILE_PATH = "compiler_test"
+from tests.basilisp.helpers import CompileFn, get_or_create_ns
 
 
 @pytest.fixture(scope="module", autouse=True)
@@ -49,18 +46,8 @@ def test_ns() -> str:
 
 
 @pytest.fixture
-def test_ns_sym(test_ns: str) -> sym.Symbol:
-    return sym.symbol(test_ns)
-
-
-@pytest.fixture
-def ns(test_ns: str, test_ns_sym: sym.Symbol) -> runtime.Namespace:
-    get_or_create_ns(test_ns_sym)
-    with runtime.ns_bindings(test_ns) as ns:
-        try:
-            yield ns
-        finally:
-            runtime.Namespace.remove(test_ns_sym)
+def compiler_file_path() -> str:
+    return "compiler_test"
 
 
 @pytest.fixture
@@ -81,30 +68,6 @@ def async_to_sync(asyncf, *args, **kwargs):
     return loop.run_until_complete(asyncf(*args, **kwargs))
 
 
-CompileFn = Callable[[str], Any]
-
-
-@pytest.fixture
-def lcompile(ns: runtime.Namespace) -> CompileFn:
-    def _lcompile(
-        s: str,
-        resolver: Optional[reader.Resolver] = None,
-        opts: Optional[Dict[str, bool]] = None,
-    ):
-        """Compile and execute the code in the input string.
-
-        Return the resulting expression."""
-        ctx = compiler.CompilerContext(COMPILER_FILE_PATH, opts=opts)
-
-        last = None
-        for form in reader.read_str(s, resolver=resolver):
-            last = compiler.compile_and_exec_form(form, ctx, ns)
-
-        return last
-
-    return _lcompile
-
-
 class TestLiterals:
     def test_nil(self, lcompile: CompileFn):
         assert None is lcompile("nil")
@@ -309,14 +272,16 @@ def test_def_docstring_is_string(self, lcompile: CompileFn, ns: runtime.Namespac
         with pytest.raises(compiler.CompilerException):
             lcompile("(def a :not-a-docstring :a)")
 
-    def test_compiler_metadata(self, lcompile: CompileFn, ns: runtime.Namespace):
+    def test_compiler_metadata(
+        self, lcompile: CompileFn, ns: runtime.Namespace, compiler_file_path: str
+    ):
         lcompile('(def ^{:doc "Super cool docstring"} unique-oeuene :a)')
 
         var = ns.find(sym.symbol("unique-oeuene"))
         meta = var.meta
 
         assert 1 == meta.val_at(kw.keyword("line"))
-        assert COMPILER_FILE_PATH == meta.val_at(kw.keyword("file"))
+        assert compiler_file_path == meta.val_at(kw.keyword("file"))
         assert 1 == meta.val_at(kw.keyword("col"))
         assert sym.symbol("unique-oeuene") == meta.val_at(kw.keyword("name"))
         assert ns == meta.val_at(kw.keyword("ns"))
@@ -3323,7 +3288,7 @@ def test_warning_for_nested_let_if_warning_enabled(
         ) in caplog.record_tuples
 
     def test_no_warning_for_nested_let_if_warning_disabled(
-        self, lcompile: CompileFn, caplog
+        self, lcompile: CompileFn, ns: runtime.Namespace, caplog
     ):
         lcompile(
             """

tests/basilisp/conftest.py

@@ -1,8 +1,61 @@
 import sys
+from typing import Dict, Optional
 
 import pytest
 
+import basilisp.lang.compiler as compiler
+import basilisp.lang.reader as reader
+import basilisp.lang.runtime as runtime
+import basilisp.lang.symbol as sym
+from tests.basilisp.helpers import CompileFn, get_or_create_ns
+
 
 @pytest.fixture(params=[3, 4] if sys.version_info < (3, 8) else [3, 4, 5])
 def pickle_protocol(request) -> int:
     return request.param
+
+
+@pytest.fixture
+def core_ns_sym() -> sym.Symbol:
+    return runtime.CORE_NS_SYM
+
+
+@pytest.fixture
+def core_ns(core_ns_sym: sym.Symbol) -> runtime.Namespace:
+    return get_or_create_ns(core_ns_sym)
+
+
+@pytest.fixture
+def test_ns_sym(test_ns: str) -> sym.Symbol:
+    return sym.symbol(test_ns)
+
+
+@pytest.fixture
+def ns(test_ns: str, test_ns_sym: sym.Symbol) -> runtime.Namespace:
+    get_or_create_ns(test_ns_sym)
+    with runtime.ns_bindings(test_ns) as ns:
+        try:
+            yield ns
+        finally:
+            runtime.Namespace.remove(test_ns_sym)
+
+
+@pytest.fixture
+def lcompile(ns: runtime.Namespace, compiler_file_path: str) -> CompileFn:
+    def _lcompile(
+        s: str,
+        resolver: Optional[reader.Resolver] = None,
+        opts: Optional[Dict[str, bool]] = None,
+    ):
+        """Compile and execute the code in the input string.
+
+        Return the resulting expression."""
+        ctx = compiler.CompilerContext(compiler_file_path, opts=opts)
+
+        last = None
+        for form in reader.read_str(s, resolver=resolver):
+            last = compiler.compile_and_exec_form(form, ctx, ns)
+
+        return last
+
+    return _lcompile

tests/basilisp/helpers.py

@@ -1,8 +1,10 @@
-from typing import Tuple
+from typing import Any, Callable, Tuple
 
 import basilisp.lang.symbol as sym
 from basilisp.lang.runtime import CORE_NS_SYM, Namespace
 
+CompileFn = Callable[[str], Any]
+
 
 def get_or_create_ns(
     name: sym.Symbol, refer: Tuple[sym.Symbol] = (CORE_NS_SYM,)

tests/basilisp/langutil_test.py

@@ -1,4 +1,9 @@
-from basilisp.lang.util import _MUNGE_REPLACEMENTS, demunge
+import builtins
+import keyword
+
+import pytest
+
+from basilisp.lang.util import _MUNGE_REPLACEMENTS, demunge, munge
 
 
 def test_demunge():
@@ -10,3 +15,33 @@ def test_demunge():
     assert "random--V--" == demunge("random__V__")
     assert "hi-how-are-you?" == demunge("hi_how_are_you__Q__")
     assert "hi-how-are-you----" == demunge("hi_how_are_you____")
+
+
+@pytest.mark.parametrize(
+    "expected,input",
+    [
+        ("__PLUS__", "+"),
+        ("_", "-"),
+        ("__STAR__ns__STAR__", "*ns*"),
+        ("__DIV__", "/"),
+        ("__LT__", "<"),
+        ("__GT__", ">"),
+        ("send__BANG__", "send!"),
+        ("__EQ__", "="),
+        ("string__Q__", "string?"),
+        ("__IDIV__", "\\"),
+        ("__AMP__form", "&form"),
+    ],
+)
+def test_munge_disallows_syms(expected, input):
+    assert expected == munge(input)
+
+
+def test_munge_disallows_python_builtins():
+    for name in builtins.__dict__.keys():
+        assert f"{name}_" == munge(name)
+
+
+def test_munge_disallows_python_kws():
+    for kw in keyword.kwlist:
+        assert f"{kw}_" == munge(kw)