Fix deftype/defrecord constructors #1025 (#1026)

Fixes #1025

Author: mitch-kyle

CHANGELOG.md

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### Fixed
  * Fix a bug where the compiler would always generate inline function definitions even if the `inline-functions` compiler option is disabled (#1023)
+ * Fix a bug where `defrecord`/`deftype` constructors could not be used in the type's methods. (#1025)
 
 ## [v0.2.1]
 ### Changed

src/basilisp/core.lpy

@@ -6592,6 +6592,7 @@
 
         {:keys [interfaces methods]} (collect-methods method-impls)]
     `(do
+       (declare ~type-name ~ctor-name)
        (deftype* ~type-name ~fields
          :implements [~@interfaces
                       ~'basilisp.lang.interfaces/IType
@@ -6765,6 +6766,7 @@
     (validate-record-methods methods)
 
     `(do
+       (declare ~type-name ~ctor-name ~map-ctor)
        (deftype* ~type-name ~record-fields
          :implements [~@interfaces]
 

tests/basilisp/test_defrecord.lpy

@@ -1,20 +1,31 @@
 (ns tests.basilisp.test-defrecord
   (:import abc)
   (:require
-   [basilisp.test :refer [deftest is testing]]))
+   [basilisp.test :refer [deftest is testing are]]))
 
 (deftype Square [dim]
   (__eq__ [this other]
     (and (instance? Square other)
          (= dim (.-dim other)))))
 
+(deftype InvokeConstructorsType []
+  (__call__ [this ctor]
+    (case ctor
+      :positional (->InvokeConstructorsType)
+      :dot        (InvokeConstructorsType.))))
+
 (deftest deftype-constructors
   (let [elems [(tests.basilisp.test-defrecord.Square. 1)
                (Square. 1)
                (new tests.basilisp.test-defrecord.Square 1)
                (new Square 1)
                (tests.basilisp.test-defrecord/Square 1)]]
-    (is (apply = elems))))
+    (is (apply = elems)))
+  (testing "can invoke own constructors"
+    (let [invoke (->InvokeConstructorsType)]
+      (are [k] (instance? InvokeConstructorsType (invoke k))
+        :positional
+        :dot))))
 
 (deftest deftype-reader-form
   (testing "type"
@@ -184,13 +195,26 @@
   (area [self]
     (* 3.14 radius radius)))
 
+(defrecord InvokeConstructorsRecord []
+  (__call__ [self ctor]
+    (case ctor
+      :map        (map->InvokeConstructorsRecord self)
+      :positional (->InvokeConstructorsRecord)
+      :dot        (InvokeConstructorsRecord.))))
+
 (deftest defrecord-constructors
   (let [elems [(tests.basilisp.test-defrecord.Circle. 1)
                (Circle. 1)
                (new tests.basilisp.test-defrecord.Circle 1)
                (new Circle 1)
                (tests.basilisp.test-defrecord/Circle 1)]]
-    (is (apply = elems))))
+    (is (apply = elems)))
+  (testing "can invoke own constructors"
+    (let [invoke (->InvokeConstructorsRecord)]
+      (are [k] (instance? InvokeConstructorsRecord (invoke k))
+        :map
+        :positional
+        :dot))))
 
 (deftest defrecord-with-methods
   (let [c  (->Circle 1)