Catch other exceptions in the test runner and print the traceback (#235)

Author: chrisrink10

src/basilisp/test.lpy

@@ -11,6 +11,10 @@
   [test-var]
   (swap! collected-tests conj test-var))
 
+(def ^:dynamic *test-name* nil)
+(def ^:dynamic *test-section* nil)
+(def ^:dynamic *test-failures* nil)
+
 (defmacro is
   "Assert that expr is true. Must appear inside of a deftest form."
   ([expr]
@@ -32,13 +36,13 @@
             actual#   ~actual
             expected# ~expected]
         (when-not computed#
-          ;; Collect test failures in the `failures` atom created
-          ;; by `deftest`.
-          (swap! ~'failures
+          ;; Collect test failures in the atom bound to
+          ;; `*test-failures*` by `deftest`.
+          (swap! *test-failures*
                  conj
                  [~msg
-                  {:test-name    ~'test-name
-                   :test-section ~'test-section
+                  {:test-name    *test-name*
+                   :test-section *test-section*
                    :expr         (quote ~expr)
                    :line         ~line-no
                    :actual       actual#
@@ -49,9 +53,9 @@
   around the test or group of tests contained inside. Must appear inside
   of a deftest form."
   [msg & body]
-  `(let [~'test-section (if ~'test-section
-                          (str ~'test-section " :: " ~msg)
-                          ~msg)]
+  `(binding [*test-section* (if *test-section*
+                              (str *test-section* " :: " ~msg)
+                              ~msg)]
      ~@body))
 
 (defmacro deftest
@@ -67,12 +71,12 @@
     `(do
        (defn ~test-name-sym
          []
-         (binding [*ns* (the-ns ~test-ns-name)]
-           (let [~'test-name    ~test-name-str
-                 ~'test-section nil
-                 ~'failures     (atom [])]
-             ~@body
-             {:failures (deref ~'failures)})))
+         (binding [*ns*            (the-ns ~test-ns-name)
+                   *test-name*     ~test-name-str
+                   *test-section*  nil
+                   *test-failures* (atom [])]
+           ~@body
+           {:failures (deref *test-failures*)}))
 
        (add-test! (var ~test-name-sym))
        (reset! current-ns (the-ns ~test-ns-name)))))

src/basilisp/testrunner.py

@@ -1,9 +1,9 @@
 import importlib
+import traceback
 from typing import Optional, Callable
 
 import pytest
 
-import basilisp.lang.exception as lexc
 import basilisp.lang.keyword as kw
 import basilisp.lang.map as lmap
 import basilisp.lang.runtime as runtime
@@ -52,6 +52,29 @@ def _reset_collected_tests() -> None:
     return var.value.reset(vec.Vector.empty())
 
 
+class TestFailuresInfo(Exception):
+    __slots__ = ('_msg', '_data',)
+
+    def __init__(self, message: str, data: lmap.Map) -> None:
+        super().__init__()
+        self._msg = message
+        self._data = data
+
+    def __repr__(self):
+        return f"basilisp.testrunner.TestFailuresInfo({self._msg}, {lrepr(self._data)})"
+
+    def __str__(self):
+        return f"{self._msg} {lrepr(self._data)}"
+
+    @property
+    def data(self) -> lmap.Map:
+        return self._data
+
+    @property
+    def message(self) -> str:
+        return self._msg
+
+
 TestFunction = Callable[[], Optional[vec.Vector]]
 
 
@@ -112,12 +135,12 @@ def runtest(self):
         results: lmap.Map = self._run_test()
         failures: Optional[vec.Vector] = results.entry(_FAILURES_KW)
         if runtime.to_seq(failures):
-            raise lexc.ExceptionInfo("Test failures", lmap.map(results))
+            raise TestFailuresInfo("Test failures", lmap.map(results))
 
     def repr_failure(self, excinfo):
         """Representation function called when self.runtest() raises an
         exception."""
-        if isinstance(excinfo.value, lexc.ExceptionInfo):
+        if isinstance(excinfo.value, TestFailuresInfo):
             exc = excinfo.value
             failures = exc.data.entry(_FAILURES_KW)
             messages = []
@@ -142,7 +165,13 @@ def repr_failure(self, excinfo):
                 ]))
 
             return "\n\n".join(messages)
-        return None
+        elif isinstance(excinfo.value, Exception):
+            exc = excinfo.value
+            messages = [f"ERROR in ({self.name}) ({self._filename})", "\n\n"]
+            messages.extend(traceback.format_exception(Exception, exc, exc.__traceback__))
+            return "".join(messages)
+        else:
+            return None
 
     def reportinfo(self):
         return self.fspath, 0, self.name