Fix an erroneous compiler warning on Var redef (#917)

Fixes #916

Author: chrisrink10

CHANGELOG.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
  * Fix a bug where nested quotation marks were not escaped properly by various print functions and at the REPL (#894)
  * Fix a bug that caused a syntax error when presenting any filepath that includes the MS-Windows `\` file separator to the cli run command (#912)
  * Fix a bug where the core functions `symbol` and `keyword` would not accept non-string data types (#911)
+ * Fix a bug where the compiler would emit warnings on when a Var was redef'ed even if that Var was initially defined with `^:redef` metadata (#916)
 
 ### Other
  * Update Sphinx documentation theme (#909)

src/basilisp/lang/compiler/analyzer.py

@@ -66,10 +66,12 @@
     SYM_MACRO_META_KEY,
     SYM_MUTABLE_META_KEY,
     SYM_NO_INLINE_META_KEY,
+    SYM_NO_WARN_ON_REDEF_META_KEY,
     SYM_NO_WARN_ON_SHADOW_META_KEY,
     SYM_NO_WARN_WHEN_UNUSED_META_KEY,
     SYM_PRIVATE_META_KEY,
     SYM_PROPERTY_META_KEY,
+    SYM_REDEF_META_KEY,
     SYM_STATICMETHOD_META_KEY,
     SYM_TAG_META_KEY,
     VAR_IS_PROTOCOL_META_KEY,
@@ -899,6 +901,27 @@ def _await_ast(form: ISeq, ctx: AnalyzerContext) -> Await:
     )
 
 
+def __should_warn_on_redef(
+    current_ns: runtime.Namespace,
+    defsym: sym.Symbol,
+    def_meta: Optional[lmap.PersistentMap],
+) -> bool:
+    """Return True if the compiler should emit a warning about this name being redefined."""
+    if def_meta is not None and def_meta.val_at(SYM_NO_WARN_ON_REDEF_META_KEY, False):
+        return False
+
+    if defsym not in current_ns.interns:
+        return False
+
+    var = current_ns.find(defsym)
+    assert var is not None, f"Var {defsym} cannot be none here"
+
+    if var.meta is not None and var.meta.val_at(SYM_REDEF_META_KEY):
+        return False
+    else:
+        return bool(var.is_bound)
+
+
 def _def_ast(  # pylint: disable=too-many-locals,too-many-statements
     form: ISeq, ctx: AnalyzerContext
 ) -> Def:
@@ -996,6 +1019,13 @@ def _def_ast(  # pylint: disable=too-many-locals,too-many-statements
     # its meta may contain values which fail to compile.
     bare_name = sym.symbol(name.name)
 
+    # Warn if this symbol is potentially being redefined (if the Var was
+    # previously bound)
+    if __should_warn_on_redef(current_ns, bare_name, def_meta):
+        logger.warning(
+            f"redefining Var '{bare_name}' in namespace {current_ns}:{def_loc[0]}"
+        )
+
     ns_sym = sym.symbol(current_ns.name)
     var = Var.intern_unbound(
         ns_sym,

src/basilisp/lang/compiler/generator.py

@@ -48,7 +48,6 @@
     INTERFACE_KW,
     REST_KW,
     SYM_DYNAMIC_META_KEY,
-    SYM_NO_WARN_ON_REDEF_META_KEY,
     SYM_REDEF_META_KEY,
     VAR_IS_PROTOCOL_META_KEY,
 )
@@ -827,30 +826,6 @@ def _await_to_py_ast(ctx: GeneratorContext, node: Await) -> GeneratedPyAST[ast.e
     )
 
 
-def __should_warn_on_redef(
-    ctx: GeneratorContext,
-    defsym: sym.Symbol,
-    safe_name: str,
-    def_meta: lmap.PersistentMap,
-) -> bool:
-    """Return True if the compiler should emit a warning about this name being redefined."""
-    no_warn_on_redef = def_meta.val_at(SYM_NO_WARN_ON_REDEF_META_KEY, False)
-    if no_warn_on_redef:
-        return False
-
-    current_ns = ctx.current_ns
-    if defsym in current_ns.interns:
-        var = current_ns.find(defsym)
-        assert var is not None, f"Var {defsym} cannot be none here"
-
-        if var.meta is not None and var.meta.val_at(SYM_REDEF_META_KEY):
-            return False
-        else:
-            return bool(var.is_bound)
-    else:
-        return safe_name in current_ns.module.__dict__
-
-
 @_with_ast_loc
 def _def_to_py_ast(  # pylint: disable=too-many-locals
     ctx: GeneratorContext, node: Def
@@ -878,14 +853,6 @@ def _def_to_py_ast(  # pylint: disable=too-many-locals
         else []
     )
 
-    # Warn if this symbol is potentially being redefined (if the Var was
-    # previously bound)
-    if node.var.is_bound and __should_warn_on_redef(ctx, defsym, safe_name, def_meta):
-        logger.warning(
-            f"redefining local Python name '{safe_name}' in module "
-            f"'{ctx.current_ns.module.__name__}' ({node.env.ns}:{node.env.line})"
-        )
-
     if node.init is not None:
         # Since Python function definitions always take the form `def name(...):`,
         # it is redundant to assign them to the their final name after they have