Fixed a bug where private Vars could be referenced from a Namespace via alias (#514)

Author: chrisrink10

CHANGELOG.md

@@ -28,7 +28,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
  * Fixed a reader bug where no exception was being thrown splicing reader conditional forms appeared outside of valid splicing contexts (#470)
  * Fixed a bug where fully Namespace-qualified symbols would not resolve if the current Namespace did not alias the referenced Namespace (#479)
  * Fixed a bug where the `quote` special form allowed more than one argument and raised an unintended exception when no argument was provided (#497)
- * Fixed a bug where compiler options specified via command-line argument or environment variable were not honored by the importer (#???)
+ * Fixed a bug where compiler options specified via command-line argument or environment variable were not honored by the importer (#507)
+ * Fixed a bug where private Vars from other Namespaces could be referenced if the Namespace was aliased when it was required (#514)
 
 ## [v0.1.dev12] - 2020-01-26
 ### Added

src/basilisp/lang/compiler/analyzer.py

@@ -2485,6 +2485,11 @@ def __resolve_namespaced_symbol_in_ns(  # pylint: disable=too-many-branches
                 f"unable to resolve symbol '{sym.symbol(form.name, ns_sym.name)}' in this context",
                 form=form,
             )
+        elif v.meta is not None and v.meta.val_at(SYM_PRIVATE_META_KEY, False):
+            raise AnalyzerException(
+                f"cannot resolve private Var {form.name} from namespace {form.ns}",
+                form=form,
+            )
         return VarRef(form=form, var=v, env=ctx.get_node_env(pos=ctx.syntax_position),)
 
     return None

tests/basilisp/compiler_test.py

@@ -3255,6 +3255,27 @@ def test_aliased_var_does_not_resolve(
         finally:
             runtime.Namespace.remove(other_ns_name)
 
+    def test_private_aliased_var_does_not_resolve(
+        self, lcompile: CompileFn, ns: runtime.Namespace
+    ):
+        current_ns: runtime.Namespace = ns
+        other_ns_name = sym.symbol("other.ns")
+        private_var_sym = sym.symbol("m")
+        try:
+            other_ns = get_or_create_ns(other_ns_name)
+            current_ns.add_alias(other_ns, sym.symbol("other"))
+
+            private_var = Var(
+                other_ns, private_var_sym, meta=lmap.map({SYM_PRIVATE_META_KEY: True})
+            )
+            private_var.value = kw.keyword("private-var")
+            other_ns.intern(private_var_sym, private_var)
+
+            with pytest.raises(compiler.CompilerException):
+                lcompile("(other/m :arg)")
+        finally:
+            runtime.Namespace.remove(other_ns_name)
+
     def test_aliased_macro_symbol_resolution(
         self, lcompile: CompileFn, ns: runtime.Namespace
     ):