Stop chaining macroexpansion exceptions during compilation (#853)

Fixes #852

---------

Co-authored-by: Christopher Rink <[email protected]>

Author: chrisrink10

CHANGELOG.md

@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
  * Added filename metadata to compiler exceptions (#844)
  * Added a compile-time warning for attempting to call a function with an unsupported number of arguments (#671)
 
+### Changed
+ * Cause exceptions arising from compilation issues during macroexpansion will no longer be nested for each level of macroexpansion (#852)  
+
 ### Fixed
  * Fix a bug where `basilisp.lang.compiler.exception.CompilerException` would nearly always suppress line information in it's `data` map (#845)
  * Fix a bug where the function returned by `partial` retained the meta, arities, and `with_meta` method of the wrapped function rather than creating new ones (#847)

src/basilisp/lang/compiler/analyzer.py

@@ -806,10 +806,10 @@ def _call_args_ast(
 
                     kw_map[munged_k] = _analyze_form(v, ctx)
 
-            except ValueError:
+            except ValueError as e:
                 raise ctx.AnalyzerException(
                     "keyword arguments must appear in key/value pairs", form=form
-                ) from ValueError
+                ) from e
             else:
                 kwargs = lmap.map(kw_map)
         else:
@@ -2509,6 +2509,12 @@ def _invoke_ast(form: Union[llist.PersistentList, ISeq], ctx: AnalyzerContext) -
                 expanded = fn.var.value(macro_env, form, *form.rest)
                 return __handle_macroexpanded_ast(form, expanded, ctx)
             except Exception as e:
+                if isinstance(e, CompilerException) and (  # pylint: disable=no-member
+                    e.phase == CompilerPhase.MACROEXPANSION
+                ):
+                    # Do not chain macroexpansion exceptions since they don't
+                    # actually add anything of value over the cause exception
+                    raise
                 raise CompilerException(
                     "error occurred during macroexpansion",
                     filename=ctx.filename,