Don't remove basilisp.core in tests (#212)

Author: chrisrink10

tests/basilisp/compiler_test.py

@@ -18,7 +18,7 @@
 import basilisp.lang.symbol as sym
 import basilisp.lang.vector as vec
 import basilisp.reader as reader
-from basilisp.lang.runtime import Namespace, Var
+from basilisp.lang.runtime import Var
 from basilisp.main import init
 from basilisp.util import Maybe
 
@@ -48,7 +48,6 @@ def test_ns() -> str:
 def ns_var(test_ns: str):
     runtime.init_ns_var(which_ns=runtime._CORE_NS)
     yield runtime.set_current_ns(test_ns)
-    Namespace.remove(sym.symbol(runtime._CORE_NS))
 
 
 @pytest.fixture
@@ -682,7 +681,7 @@ def test_unquote(ns_var: Var):
 
 
 def test_unquote_splicing(ns_var: Var, resolver: reader.Resolver):
-    with pytest.raises(runtime.RuntimeException):
+    with pytest.raises(TypeError):
         lcompile("~@[1 2 3]")
 
     assert llist.l(1, 2, 3) == lcompile("`(~@[1 2 3])")

tests/basilisp/namespace_test.py

@@ -46,8 +46,7 @@ def test_create_ns(ns_sym: sym.Symbol, ns_cache: patch):
 
 
 @pytest.fixture
-def ns_cache_with_existing_ns(ns_sym: sym.Symbol,
-                              core_ns_sym: sym.Symbol,
+def ns_cache_with_existing_ns(ns_sym: sym.Symbol, core_ns_sym: sym.Symbol,
                               core_ns: Namespace) -> patch:
     """Patch the Namespace cache with a test fixture with an existing namespace."""
     return patch('basilisp.lang.runtime.Namespace._NAMESPACES',
@@ -68,26 +67,6 @@ def test_get_existing_ns(ns_sym: sym.Symbol,
         assert len(cache.deref().keys()) == 2
 
 
-def test_get_existing_ns_with_get(ns_sym: sym.Symbol,
-                                  ns_cache_with_existing_ns: patch):
-    with ns_cache_with_existing_ns as cache:
-        assert len(cache.deref().keys()) == 2
-        ns = Namespace.get(ns_sym)
-        assert isinstance(ns, Namespace)
-        assert ns.name == ns_sym.name
-        assert len(cache.deref().keys()) == 2
-
-
-def test_get_nil_for_non_existent_ns(ns_sym: sym.Symbol):
-    with patch('basilisp.lang.runtime.Namespace._NAMESPACES',
-               atom.Atom(
-                   lmap.map({}))) as cache:
-        assert len(cache.deref().keys()) == 0
-        ns = Namespace.get(ns_sym)
-        assert ns is None
-        assert len(cache.deref().keys()) == 0
-
-
 def test_remove_ns(ns_sym: sym.Symbol, ns_cache_with_existing_ns: patch):
     with ns_cache_with_existing_ns as cache:
         assert len(cache.deref().keys()) == 2
@@ -193,8 +172,6 @@ def other_ns(core_map: sym.Symbol,
 
     yield runtime.set_current_ns(test_ns).value
 
-    Namespace.remove(sym.symbol(runtime._CORE_NS))
-
 
 def test_refer_core(core_ns_sym: sym.Symbol,
                     other_ns: Namespace,

tests/basilisp/reader_test.py

@@ -11,7 +11,7 @@
 import basilisp.lang.util as langutil
 import basilisp.lang.vector as vec
 import basilisp.reader as reader
-from basilisp.lang.runtime import Namespace, Var
+from basilisp.lang.runtime import Var
 
 
 @pytest.fixture
@@ -23,7 +23,6 @@ def test_ns() -> str:
 def ns_var(test_ns: str):
     runtime.init_ns_var(which_ns=runtime._CORE_NS)
     yield runtime.set_current_ns(test_ns)
-    Namespace.remove(sym.symbol(runtime._CORE_NS))
 
 
 def read_str_first(s, resolver: reader.Resolver = None, data_readers=None):

tests/basilisp/runtime_test.py

@@ -252,7 +252,6 @@ def test_trampoline_args():
 def core_ns():
     ns_var = runtime.init_ns_var(which_ns=runtime._CORE_NS)
     yield ns_var.value
-    runtime.Namespace.remove(sym.symbol(runtime._CORE_NS))
 
 
 def test_resolve_alias(core_ns):