Change the default user namespace to basilisp.user (#466)

* Change the default user namespace to `basilisp.user`

* MyPy and PyLint working against each other ultimately just hurts me

Author: chrisrink10

.prospector.yaml

@@ -20,10 +20,18 @@ pep8:
   options:
     max-line-length: 120
 
+pyflakes:
+  disable:
+    - F821
+
 pylint:
   disable:
+    - import-outside-toplevel
     - len-as-condition
+    - logging-format-interpolation
     - logging-fstring-interpolation
+    - no-else-continue
+    - no-else-raise
     - no-else-return
     - protected-access
     - unsubscriptable-object

CHANGELOG.md

@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Changed
+ * Change the default user namespace to `basilisp.user` (#466)
 
 ## [v0.1.dev12] - 2020-01-26
 ### Added

Pipfile.lock

@@ -13,18 +13,18 @@ Once Basilisp is installed, you can enter into the REPL using::
 In Basilisp's REPL, you now have the full power of Basilisp at your disposal.
 It is customary to write a ``Hello, World!`` when starting out in a new language, so we'll do that here::
 
-    user=> (print "Hello, World!")
+    basilisp.user=> (print "Hello, World!")
     Hello, World!
     nil
 
 Or perhaps you'd like to try something a little more exciting, like performing some arithmetic::
 
-    user=> (+ 1 2 3 4 5)
+    basilisp.user=> (+ 1 2 3 4 5)
     15
 
 Sequences are a little more fun than simple arithmetic::
 
-    user=> (filter odd? (map inc (range 1 10)))
+    basilisp.user=> (filter odd? (map inc (range 1 10)))
     (3 5 7 9 11)
 
 There is a ton of great functionality built in to Basilisp, so feel free to poke around.

docs/gettingstarted.rst

@@ -24,13 +24,13 @@ Integers
 
 ::
 
-    user=> 1
+    basilisp.user=> 1
     1
-    user=> (builtins/type 1)
+    basilisp.user=> (builtins/type 1)
     <class 'int'>
-    user=> 1N
+    basilisp.user=> 1N
     1
-    user=> (builtins/type 1N)
+    basilisp.user=> (builtins/type 1N)
     <class 'int'>
 
 Integers are represented using numeric ``0-9`` and may be prefixed with any number of negative signs ``-``.
@@ -43,13 +43,13 @@ Floating Point
 
 ::
 
-   user=> 1.0
+   basilisp.user=> 1.0
    1.0
-   user=> (builtins/type 1.0)
+   basilisp.user=> (builtins/type 1.0)
    <class 'float'>
-   user=> 1M
+   basilisp.user=> 1M
    1
-   user=> (builtins/type 1M)
+   basilisp.user=> (builtins/type 1M)
    <class 'decimal.Decimal'>
 
 Floating point values are represented using ``0-9`` and a trailing decimal value, separated by a ``.`` character.
@@ -63,13 +63,13 @@ Complex
 
 ::
 
-    user=> 1J
+    basilisp.user=> 1J
     1J
-    user=> (builtins/type 1J)
+    basilisp.user=> (builtins/type 1J)
     <class 'complex'>
-    user=> 1.0J
+    basilisp.user=> 1.0J
     1J
-    user=> (builtins/type 1.0J)
+    basilisp.user=> (builtins/type 1.0J)
     <class 'complex'>
 
 Basilisp includes support for complex literals to match the Python VM hosts it.
@@ -83,11 +83,11 @@ Strings
 
 ::
 
-    user=> ""
+    basilisp.user=> ""
     ""
-    user=> "this is a string"
+    basilisp.user=> "this is a string"
     "this is a string"
-    user=> (builtins/type "")
+    basilisp.user=> (builtins/type "")
     <class 'str'>
 
 Strings are denoted as a series of characters enclosed by ``"`` quotation marks.
@@ -102,11 +102,11 @@ Character Literals
 
 ::
 
-    user=> \a
+    basilisp.user=> \a
     "a"
-    user=> \u03A9
+    basilisp.user=> \u03A9
     "Ω"
-    user=> \newline
+    basilisp.user=> \newline
     "
     "
 
@@ -126,13 +126,13 @@ Boolean Values
 
 ::
 
-    user=> true
+    basilisp.user=> true
     true
-    user=> (builtins/type true)
+    basilisp.user=> (builtins/type true)
     <class 'bool'>
-    user=> false
+    basilisp.user=> false
     false
-    user=> (builtins/type false)
+    basilisp.user=> (builtins/type false)
     <class 'bool'>
 
 The special values ``true`` and ``false`` correspond to Python's ``True`` and ``False`` respectively.
@@ -144,9 +144,9 @@ nil
 
 ::
 
-    user=> nil
+    basilisp.user=> nil
     nil
-    user=> (builtins/type nil)
+    basilisp.user=> (builtins/type nil)
     <class 'NoneType'>
 
 The special value ``nil`` correspond's to Python's ``None``.
@@ -167,9 +167,9 @@ Symbols
 
 ::
 
-    user=> 'sym
+    basilisp.user=> 'sym
     sym
-    user=> 'namespaced/sym
+    basilisp.user=> 'namespaced/sym
     namespaced/sym
 
 Symbolic identifiers, most often used to refer to a Var or value in Basilisp.
@@ -184,9 +184,9 @@ Keywords
 
 ::
 
-    user=> :keyword
+    basilisp.user=> :keyword
     :keyword
-    user=> :namespaced/keyword
+    basilisp.user=> :namespaced/keyword
     :namespaced/keyword
 
 Keywords are denoted by the ``:`` prefix character.
@@ -204,9 +204,9 @@ Lists
 
 ::
 
-    user=> ()
+    basilisp.user=> ()
     ()
-    user=> '(1 "2" :three)
+    basilisp.user=> '(1 "2" :three)
     (1 "2" :three)
 
 Lists are denoted with the ``()`` characters.
@@ -221,9 +221,9 @@ Vectors
 
 ::
 
-    user=> []
+    basilisp.user=> []
     []
-    user=> [1 "2" :three]
+    basilisp.user=> [1 "2" :three]
     [1 "2" :three]
 
 Vectors are denoted with the ``[]`` characters.
@@ -237,9 +237,9 @@ Maps
 
 ::
 
-    user=> {}
+    basilisp.user=> {}
     {}
-    user=> {1 "2" :three 3}
+    basilisp.user=> {1 "2" :three 3}
     {1 "2" :three 3}
 
 Maps are denoted with the ``{}`` characters.
@@ -253,9 +253,9 @@ Sets
 
 ::
 
-    user=> #{}
+    basilisp.user=> #{}
     #{}
-    user=> #{1 "2" :three}
+    basilisp.user=> #{1 "2" :three}
     #{1 "2" :three}
 
 Sets are denoted with the ``#{}`` characters.
@@ -277,11 +277,11 @@ Metadata
 
 ::
 
-    user=> (meta '^:macro s)
+    basilisp.user=> (meta '^:macro s)
     {:macro true}
-    user=> (meta '^str s)
+    basilisp.user=> (meta '^str s)
     {:tag str}
-    user=> (meta '^{:has-meta true} s)
+    basilisp.user=> (meta '^{:has-meta true} s)
     {:has-meta true}
 
 Metadata can be applied to the following form by specifying metadata before the form as ``^meta form``.

docs/reader.rst

@@ -729,7 +729,7 @@ def _def_ast(  # pylint: disable=too-many-branches,too-many-locals
     #        :file "<REPL Input>"
     #        :line 1
     #        :name 'some-name
-    #        :ns   ((.- basilisp.lang.runtime/Namespace get) 'user)}
+    #        :ns   ((.- basilisp.lang.runtime/Namespace get) 'basilisp.user)}
     #       some-name
     #       "some value")
     meta_ast = _analyze_form(

src/basilisp/lang/compiler/analyzer.py

@@ -57,7 +57,7 @@
 CORE_NS = "basilisp.core"
 NS_VAR_NAME = "*ns*"
 NS_VAR_NS = CORE_NS
-REPL_DEFAULT_NS = "user"
+REPL_DEFAULT_NS = "basilisp.user"
 
 # Private string constants
 _GENERATED_PYTHON_VAR_NAME = "*generated-python*"
@@ -661,14 +661,15 @@ def is_match(entry: Tuple[sym.Symbol, Any]) -> bool:
 
         return is_match
 
+    # pylint: disable=unnecessary-comprehension
     def __complete_alias(
         self, prefix: str, name_in_ns: Optional[str] = None
     ) -> Iterable[str]:
         """Return an iterable of possible completions matching the given
         prefix from the list of aliased namespaces. If name_in_ns is given,
         further attempt to refine the list to matching names in that namespace."""
         candidates = filter(
-            Namespace.__completion_matcher(prefix), [(s, n) for s, n in self.aliases]
+            Namespace.__completion_matcher(prefix), ((s, n) for s, n in self.aliases)
         )
         if name_in_ns is not None:
             for _, candidate_ns in candidates:
@@ -707,6 +708,7 @@ def __complete_imports_and_aliases(
             for candidate_name, _ in candidates:
                 yield f"{candidate_name}/"
 
+    # pylint: disable=unnecessary-comprehension
     def __complete_interns(
         self, value: str, include_private_vars: bool = True
     ) -> Iterable[str]:
@@ -722,16 +724,17 @@ def is_match(entry: Tuple[sym.Symbol, Var]) -> bool:
 
         return map(
             lambda entry: f"{entry[0].name}",
-            filter(is_match, [(s, v) for s, v in self.interns]),
+            filter(is_match, ((s, v) for s, v in self.interns)),
         )
 
+    # pylint: disable=unnecessary-comprehension
     def __complete_refers(self, value: str) -> Iterable[str]:
         """Return an iterable of possible completions matching the given
         prefix from the list of referred Vars."""
         return map(
             lambda entry: f"{entry[0].name}",
             filter(
-                Namespace.__completion_matcher(value), [(s, v) for s, v in self.refers]
+                Namespace.__completion_matcher(value), ((s, v) for s, v in self.refers)
             ),
         )
 

src/basilisp/lang/runtime.py

@@ -15,23 +15,23 @@ class TestREPL:
     def test_no_input(self):
         runner = CliRunner()
         result = runner.invoke(cli, ["repl"], input="")
-        assert "user=> " == result.stdout
+        assert "basilisp.user=> " == result.stdout
 
     def test_newline(self):
         runner = CliRunner()
         result = runner.invoke(cli, ["repl"], input="\n")
-        assert "user=> user=> " == result.stdout
+        assert "basilisp.user=> basilisp.user=> " == result.stdout
 
     def test_simple_expression(self):
         runner = CliRunner()
         result = runner.invoke(cli, ["repl"], input="(+ 1 2)")
-        assert "user=> 3\nuser=> " == result.stdout
+        assert "basilisp.user=> 3\nbasilisp.user=> " == result.stdout
 
     def test_syntax_error(self):
         runner = CliRunner()
         result = runner.invoke(cli, ["repl"], input="(+ 1 2")
         assert (
-            "basilisp.lang.reader.SyntaxError: Unexpected EOF in list\nuser=> "
+            "basilisp.lang.reader.SyntaxError: Unexpected EOF in list\nbasilisp.user=> "
             in result.stdout
         )
 
@@ -40,15 +40,15 @@ def test_compiler_error(self):
         result = runner.invoke(cli, ["repl"], input="(fn*)")
         assert (
             "basilisp.lang.compiler.exception.CompilerException: fn form "
-            "must match: (fn* name? [arg*] body*) or (fn* name? method*)\nuser=> "
+            "must match: (fn* name? [arg*] body*) or (fn* name? method*)\nbasilisp.user=> "
         ) in result.stdout
 
     def test_other_exception(self):
         runner = CliRunner()
         result = runner.invoke(
             cli, ["repl"], input='(throw (python/Exception "CLI test"))'
         )
-        assert "Exception: CLI test\nuser=> " in result.stdout
+        assert "Exception: CLI test\nbasilisp.user=> " in result.stdout
 
 
 class TestRun:

tests/basilisp/cli_test.py

@@ -6,7 +6,7 @@ parallel_show_output = {env:TOX_SHOW_OUTPUT:true}
 setenv =
     BASILISP_DO_NOT_CACHE_NAMESPACES = true
 deps =
-    coverage==4.5.4
+    coverage
     six==1.10.0
 commands =
     coverage run \
@@ -20,7 +20,7 @@ commands =
 depends = py36, py37, py38
 deps =
     coveralls
-    coverage==4.5.4
+    coverage
     six==1.10.0
 passenv =
     COVERALLS_REPO_TOKEN
@@ -63,7 +63,7 @@ commands =
     mypy --config-file={toxinidir}/mypy.ini --show-error-codes src/basilisp
 
 [testenv:lint]
-deps = prospector==1.1.6.2
+deps = prospector==1.2.0
 commands =
     prospector --profile-path={toxinidir}