Use a List

Author: chrisrink10

src/singledispatch/mro.rs

@@ -3,7 +3,7 @@ use crate::singledispatch::typeref::PyTypeReference;
 use crate::singledispatch::typing::TypingModule;
 use pyo3::exceptions::PyRuntimeError;
 use pyo3::prelude::*;
-use pyo3::types::PyTuple;
+use pyo3::types::{PyList, PyTuple};
 use pyo3::{intern, Bound, PyObject, PyResult, Python};
 use std::borrow::Borrow;
 use std::cmp::Reverse;
@@ -37,7 +37,7 @@ fn get_obj_bases(cls: &Bound<'_, PyAny>) -> PyResult<Vec<PyTypeReference>> {
 fn get_obj_subclasses(cls: &Bound<'_, PyAny>) -> PyResult<HashSet<PyTypeReference>> {
     let subclasses: HashSet<_> = cls
         .call_method0(intern!(cls.py(), "__subclasses__"))?
-        .downcast::<PyTuple>()?
+        .downcast::<PyList>()?
         .iter()
         .map(|item| PyTypeReference::new(item.unbind()))
         .collect();

tests/test_singledispatch_native.py

@@ -1,3 +1,5 @@
+from collections.abc import Sequence
+
 import pytest
 from singledispatch_native import singledispatch
 
@@ -18,13 +20,27 @@ def _some_fun_str(o: int) -> str:
     return "It's an int!"
 
 
+@some_fun.register(Sequence)
+def _some_fun_sequence(l: Sequence) -> str:
+    return "Sequence: " + ", ".join(l)
+
+
+@some_fun.register(tuple)
+def _some_fun_sequence(l: tuple) -> str:
+    return "tuple: " + ", ".join(l)
+
+
 @pytest.mark.parametrize(
     "v,ret",
     [
         (None, "Got None <class 'NoneType'>"),
         ("val", "It's a string!"),
         (1, "It's an int!"),
-        # (True, "It's an int!"),
+        (True, "It's an int!"),
+        ([], "Sequence: "),
+        (["1"], "Sequence: 1"),
+        (["1", "2", "3"], "Sequence: 1, 2, 3"),
+        (("1", "2", "3"), "tuple: 1, 2, 3"),
     ]
 )
 def test_singledispatch(v, ret):