BUG: Add support for local package install from extras in local dependencies #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 97.04% 97.10% +0.06%
==========================================
Files 10 10
Lines 1454 1486 +32
==========================================
+ Hits 1411 1443 +32
Misses 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
basnijholt
changed the title
basnijholt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when specifying a local dependency with extras in the
local_dependenciessection, like:The
pip install ./local/pathpart of the extras are ignored (the non-local deps are installed correctly). This means that optional dependencies defined inmy_packageunder theextra1section are not included.Solution
This PR adds proper support for extras in local dependencies by:
*) to include all optional sectionsTests
Added several tests to verify the functionality:
The implementation maintains full backward compatibility and adds no changes to existing behavior.
📚 Documentation preview 📚: https://unidep--238.org.readthedocs.build/en/238/