Skip to content

add an option to opt-out from passing the github token #65

@brokenpip3

Description

@brokenpip3

Also note that the rate limits are for API requests, not for other types of requests.

unfortunately this is not true, github introduced rate limits everywhere, even by visiting a web page, they called it "secondary rate limit"

Just to be clear, I'm not suggesting to remove the use of the token altogther; in fact, I would leave the default as it is now, which is good; only offer an optional way to opt-out from using the token if the user knows what they're doing.

why not, make sense, I'm happy to provide more freedom to the users

I can do it myself and submit a PR.

happy to review it, I believe the best way could be:

  • removing the default, keeping the token to be optional
  • add a check if we need to pass the token as header in case it's present
  • use it in any curl call even later
  • update the readme and show how to actually pass the token to avoid the rate limit so something like:
with:
    [...]
    github-token: ${{ secrets.github.token }}

Originally posted by @brokenpip3 in #60 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions