Skip to content

Commit 7905bad

Browse files
committed
feat(qui-cli)!: remove spinner()
Use [ora](https://npmjs.com/package/ora) directly. Embedding it in qui-cli adds no functionality. BREAKING: cli.spinner() has been removed. Use Ora directly.
1 parent 658851d commit 7905bad

File tree

4 files changed

+2
-14
lines changed

4 files changed

+2
-14
lines changed

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,6 @@ Pass-through to [@inquirer/prompts](https://www.npmjs.com/package/@inquirer/prom
107107

108108
Pass-through to [shelljs](https://www.npmjs.com/package/shelljs) unix shell [API](https://github.com/shelljs/shelljs#command-reference).
109109

110-
### `cli.spinner: Ora`
111-
112-
Pass-through to [ora](https://www.npmjs.com/package/ora) terminal spinner/progress bar [API](https://github.com/sindresorhus/ora#usage).
113-
114110
### `cli.validators`
115111

116112
Collection of validators for use with `cli.prompts` (or other places where validation of text is useful).

packages/qui-cli/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@
3939
"@battis/qui-cli.root": "workspace:*",
4040
"@battis/qui-cli.shell": "workspace:*",
4141
"@battis/qui-cli.validators": "workspace:*",
42-
"@inquirer/prompts": "^2.3.1",
43-
"ora": "^6.3.1"
42+
"@inquirer/prompts": "^2.3.1"
4443
},
4544
"devDependencies": {
4645
"@battis/eslint-config": "latest",

packages/qui-cli/src/cli.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { Root } from '@battis/qui-cli.root';
77
import { Shell, Options as ShellOptions } from '@battis/qui-cli.shell';
88
import { Validators } from '@battis/qui-cli.validators';
99
import * as prompts from '@inquirer/prompts';
10-
import spinner from 'ora';
1110

1211
export type Options = {
1312
env?: EnvOptions;
@@ -78,10 +77,7 @@ export const cli = {
7877
},
7978

8079
/** @deprecated use @inquirer/prompts directly */
81-
prompts,
82-
83-
/** @deprecated use ora directly */
84-
spinner
80+
prompts
8581
};
8682

8783
export default cli;

pnpm-lock.yaml

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)