Skip to content

Commit 0601c03

Browse files
author
Andrii Bondarchuk
committed
Improve error handling for Garmin activity updates
Wrapped Garmin activity update in a try-catch block to log errors and throw an InvalidDataException on failure. Also fixed a minor formatting issue in the assignment of activitySummary.
1 parent 4a1063e commit 0601c03

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

src/FitSyncHub.Functions/Functions/SyncIntervalsICUWithGarminHttpTriggerFunction.cs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public async Task<IActionResult> Run(
101101
}
102102

103103
activitySummary
104-
= await UpdateActivitiesWithNewTssAndReturnSummary(activities, pairedEvent, cancellationToken);
104+
= await UpdateActivitiesWithNewTssAndReturnSummary(activities, pairedEvent, cancellationToken);
105105
}
106106

107107
var garminActivity = await UpdateGarminSummaryWithIntervalsData(date, activitySummary, cancellationToken);
@@ -348,7 +348,16 @@ private static List<IntervalsIcuActivityWithNewTss> CalculateNewTssForActivities
348348
};
349349

350350
_logger.LogInformation("Updating garmin activity with Id = {Id}", activityId);
351-
await _garminConnectHttpClient.UpdateActivity(updateModel, cancellationToken);
351+
try
352+
{
353+
await _garminConnectHttpClient.UpdateActivity(updateModel, cancellationToken);
354+
}
355+
catch (Exception)
356+
{
357+
_logger.LogError("Failed to update garmin activity with Id = {Id}", activityId);
358+
throw new InvalidDataException($"Can not update garmin activity");
359+
}
360+
352361
_logger.LogInformation("Updated garmin activity with Id = {Id}", activityId);
353362

354363
return await _garminConnectHttpClient.GetActivity(activityId, cancellationToken);

0 commit comments

Comments
 (0)