Skip to content

Commit e756ebc

Browse files
author
Andrii Bondarchuk
committed
EnsureSuccessStatusCode() everywhere
1 parent 6990088 commit e756ebc

File tree

5 files changed

+15
-6
lines changed

5 files changed

+15
-6
lines changed

src/FitSyncHub.GarminConnect/HttpClients/GarminConnectHttpClient_Activity.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,10 @@ public async Task<HttpResponseMessage> UpdateActivity(
3333
request.Content = JsonContent.Create(model,
3434
GarminConnectActivitySerializerContext.Default.GarminActivityUpdateRequest);
3535

36-
return await _httpClient.SendAsync(request, cancellationToken);
36+
var response = await _httpClient.SendAsync(request, cancellationToken);
37+
response.EnsureSuccessStatusCode();
38+
39+
return response;
3740
}
3841

3942
public async Task<Stream> DownloadActivityFile(

src/FitSyncHub.IntervalsICU/HttpClients/IntervalsIcuHttpClient_Chats.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ public async Task<IReadOnlyCollection<ActivityMessageResponse>> ListAllMessages(
1515
var requestUri = $"activity/{activityId}/messages";
1616

1717
var response = await _httpClient.GetAsync(requestUri, cancellationToken);
18+
response.EnsureSuccessStatusCode();
1819

1920
var content = await response.Content.ReadAsStringAsync(cancellationToken)!;
2021
return JsonSerializer.Deserialize(content, IntervalsIcuSnakeCaseSourceGenerationContext.Default.IReadOnlyCollectionActivityMessageResponse)!;

src/FitSyncHub.IntervalsICU/HttpClients/IntervalsIcuHttpClient_Wellness.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public async Task<WellnessResponse> GetWellness(
2525
response.EnsureSuccessStatusCode();
2626

2727
var content = await response.Content.ReadAsStringAsync(cancellationToken)!;
28-
return JsonSerializer.Deserialize(content, IntervalsIcuCamelCaseSourceGenerationContext.Default.WellnessResponse)!;
28+
return JsonSerializer.Deserialize(content,
29+
IntervalsIcuCamelCaseSourceGenerationContext.Default.WellnessResponse)!;
2930
}
3031

3132
public async Task<WellnessResponse> UpdateWellness(
@@ -36,8 +37,10 @@ public async Task<WellnessResponse> UpdateWellness(
3637

3738
var jsonContent = JsonContent.Create(model, IntervalsIcuCamelCaseSourceGenerationContext.Default.WellnessRequest);
3839
var response = await _httpClient.PutAsync(requestUri, jsonContent, cancellationToken);
40+
response.EnsureSuccessStatusCode();
3941

4042
var content = await response.Content.ReadAsStringAsync(cancellationToken)!;
41-
return JsonSerializer.Deserialize(content, IntervalsIcuCamelCaseSourceGenerationContext.Default.WellnessResponse)!;
43+
return JsonSerializer.Deserialize(content,
44+
IntervalsIcuCamelCaseSourceGenerationContext.Default.WellnessResponse)!;
4245
}
4346
}

src/FitSyncHub.Strava/HttpClients/StravaHttpClient.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,11 @@ public async Task<DetailedAthleteResponse> UpdateAthlete(
4141
var requestUri = QueryHelpers.AddQueryString("athlete", queryParams);
4242

4343
var response = await _httpClient.PutAsync(requestUri, null, cancellationToken);
44-
var content = await response.Content.ReadAsStringAsync(cancellationToken);
44+
response.EnsureSuccessStatusCode();
4545

46-
return JsonSerializer.Deserialize(content, StravaHttpClientSerializerContext.Default.DetailedAthleteResponse)!;
46+
var content = await response.Content.ReadAsStringAsync(cancellationToken);
47+
return JsonSerializer.Deserialize(content,
48+
StravaHttpClientSerializerContext.Default.DetailedAthleteResponse)!;
4749
}
4850

4951
public async Task<List<SummaryActivityModelResponse>> GetActivities(
@@ -99,6 +101,7 @@ public async Task<ActivityModelResponse> UpdateActivity(
99101
var requestUri = $"activities/{activityId}";
100102
var response = await _httpClient.PutAsJsonAsync(requestUri, model,
101103
StravaHttpClientSerializerContext.Default.UpdatableActivityRequest, cancellationToken);
104+
response.EnsureSuccessStatusCode();
102105

103106
var content = await response.Content.ReadAsStringAsync(cancellationToken);
104107
return JsonSerializer.Deserialize(content, StravaHttpClientSerializerContext.Default.ActivityModelResponse)!;

src/FitSyncHub.Zwift/HttpClients/ZwiftRacingHttpClient.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ public async Task<IReadOnlyCollection<ZwiftRacingEventResponse>> GetEvent(
4242
return GetRiderHistory(riderId, default, cancellationToken);
4343
}
4444

45-
4645
public async Task<ZwiftRacingRiderResponse?> GetRiderHistory(
4746
long riderId,
4847
int? year,

0 commit comments

Comments
 (0)