Fix transaction amount_float mutator

keatliang2005 · rez1dent3 · commit 1a332e39ef64 · 2022-07-28T15:42:44.000+03:00
I have notice the mutator on the transaction model display somewhat funky. 

example i had the wallet set to 4 decimal precision, when access with `$model-&gt;amount_float`

i had `"0.0120000000000000000000000000000000000000000000000000000000000000"` as result

when i made changes above (on PR) it display correctly `"0.0120"`
diff --git a/src/Models/Transaction.php b/src/Models/Transaction.php
@@ -90,7 +90,7 @@ public function getAmountFloatAttribute(): string
             ->decimal_places;
         $decimalPlaces = $math->powTen($decimalPlacesValue);
 
-        return $math->div($this->amount, $decimalPlaces);
+        return $math->div($this->amount, $decimalPlaces, $decimalPlacesValue);
     }
 
     public function setAmountFloatAttribute(float|int|string $amount): void

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public function getAmountFloatAttribute(): string`
`90`	`90`	`->decimal_places;`
`91`	`91`	`$decimalPlaces = $math->powTen($decimalPlacesValue);`
`92`	`92`
`93`		`- return $math->div($this->amount, $decimalPlaces);`
	`93`	`+ return $math->div($this->amount, $decimalPlaces, $decimalPlacesValue);`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`public function setAmountFloatAttribute(float\|int\|string $amount): void`