bug fixed; up coverage

Author: rez1dent3

src/Models/Wallet.php

@@ -60,7 +60,14 @@ public function getTable(): string
     public function setNameAttribute(string $name): void
     {
         $this->attributes['name'] = $name;
-        $this->attributes['slug'] = Str::slug($name);
+
+        /**
+         * Must be updated only if the model does not exist
+         *  or the slug is empty
+         */
+        if (!$this->exists && !\array_key_exists('slug', $this->attributes)) {
+            $this->attributes['slug'] = Str::slug($name);
+        }
     }
 
     /**

src/Traits/HasWallet.php

@@ -84,7 +84,7 @@ public function deposit(int $amount, ?array $meta = null, bool $confirmed = true
      */
     public function withdraw(int $amount, ?array $meta = null, bool $confirmed = true): Transaction
     {
-        if (!$this->balance) {
+        if ($amount && !$this->balance) {
             throw new BalanceIsEmpty(trans('wallet::errors.wallet_empty'));
         }
 

tests/Models/ItemTax.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace Bavix\Wallet\Test\Models;
+
+use Bavix\Wallet\Interfaces\Taxing;
+
+class ItemTax extends Item implements Taxing
+{
+
+    /**
+     * @return string
+     */
+    public function getTable(): string
+    {
+        return 'items';
+    }
+
+    /**
+     * Specify the percentage of the amount.
+     * For example, the product costs $100, the equivalent of 15%.
+     * That's $115.
+     *
+     * Minimum 0; Maximum 100
+     * Example: return 7.5; // 7.5%
+     *
+     * @return float
+     */
+    public function getFeePercent(): float
+    {
+        return 7.5;
+    }
+
+}

tests/MultiWalletTest.php

@@ -251,4 +251,32 @@ public function testWalletUnique(): void
         ]);
     }
 
+    /**
+     * @return void
+     */
+    public function testGetWallet(): void
+    {
+        /**
+         * @var UserMulti $user
+         */
+        $user = factory(UserMulti::class)->create();
+
+        $firstWallet = $user->createWallet([
+            'name' => 'My Test',
+            'slug' => 'test',
+        ]);
+
+        $secondWallet = $user->getWallet('test');
+        $this->assertEquals($secondWallet->getKey(), $firstWallet->getKey());
+
+        $test2 = $user->wallets()->create([
+            'name' => 'Test2'
+        ]);
+
+        $this->assertEquals(
+            $test2->getKey(),
+            $user->getWallet('test2')->getKey()
+        );
+    }
+
 }

tests/ProductTest.php

@@ -168,4 +168,48 @@ public function testForcePay(): void
         $this->assertEquals($buyer->balance, 0);
     }
 
+    /**
+     * @return void
+     */
+    public function testPayFree(): void
+    {
+        /**
+         * @var Buyer $buyer
+         * @var Item $product
+         */
+        $buyer = factory(Buyer::class)->create();
+        $product = factory(Item::class)->create([
+            'quantity' => 1,
+        ]);
+
+        $this->assertEquals($buyer->balance, 0);
+
+        $buyer->payFree($product);
+        $this->assertEquals($buyer->balance, 0);
+        $this->assertEquals($product->balance, 0);
+
+        $buyer->refund($product);
+        $this->assertEquals($buyer->balance, 0);
+        $this->assertEquals($product->balance, 0);
+    }
+
+    /**
+     * @return void
+     * @expectedException \Bavix\Wallet\Exceptions\ProductEnded
+     */
+    public function testPayFreeOutOfStock(): void
+    {
+        /**
+         * @var Buyer $buyer
+         * @var Item $product
+         */
+        $buyer = factory(Buyer::class)->create();
+        $product = factory(Item::class)->create([
+            'quantity' => 1,
+        ]);
+
+        $this->assertNotNull($buyer->payFree($product));
+        $buyer->payFree($product);
+    }
+
 }

tests/TaxTest.php

@@ -0,0 +1,55 @@
+<?php
+
+namespace Bavix\Wallet\Test;
+
+use Bavix\Wallet\Models\Transaction;
+use Bavix\Wallet\Test\Models\Buyer;
+use Bavix\Wallet\Test\Models\ItemTax;
+
+class TaxTest extends TestCase
+{
+
+    /**
+     * @return void
+     */
+    public function testPay(): void
+    {
+        /**
+         * @var Buyer $buyer
+         * @var ItemTax $product
+         */
+        $buyer = factory(Buyer::class)->create();
+        $product = factory(ItemTax::class)->create([
+            'quantity' => 1,
+        ]);
+
+        $balance = (int) ($product->price +
+            $product->price * $product->getFeePercent() / 100);
+
+        $this->assertEquals($buyer->balance, 0);
+        $buyer->deposit($balance);
+
+        $this->assertNotEquals($buyer->balance, 0);
+        $transfer = $buyer->pay($product);
+        $this->assertNotNull($transfer);
+
+        /**
+         * @var Transaction $withdraw
+         * @var Transaction $deposit
+         */
+        $withdraw = $transfer->withdraw;
+        $deposit = $transfer->deposit;
+
+        $this->assertEquals($withdraw->amount, -$balance);
+        $this->assertEquals($deposit->amount, $product->getAmountProduct());
+        $this->assertNotEquals($deposit->amount, $withdraw->amount);
+
+        $buyer->refund($product);
+        $this->assertEquals($buyer->balance, $deposit->amount);
+        $this->assertEquals($product->balance, 0);
+
+        $buyer->withdraw($buyer->balance);
+        $this->assertEquals($buyer->balance, 0);
+    }
+
+}

tests/WalletTest.php

@@ -74,6 +74,17 @@ public function testInvalidWithdraw(): void
         $user->withdraw(-1);
     }
 
+    /**
+     * @return void
+     * @expectedException \Bavix\Wallet\Exceptions\InsufficientFunds
+     */
+    public function testInsufficientFundsWithdraw(): void
+    {
+        $user = factory(User::class)->create();
+        $user->deposit(1);
+        $user->withdraw(2);
+    }
+
     /**
      * @return void
      */

tests/factories/ItemTaxFactory.php

@@ -0,0 +1,23 @@
+<?php
+
+use Faker\Generator as Faker;
+use Bavix\Wallet\Test\Models\ItemTax;
+
+/*
+|--------------------------------------------------------------------------
+| Model Factories
+|--------------------------------------------------------------------------
+|
+| This directory should contain each of the model factory definitions for
+| your application. Factories provide a convenient way to generate new
+| model instances for testing / seeding your application's database.
+|
+*/
+
+$factory->define(ItemTax::class, function(Faker $faker) {
+    return [
+        'name' => $faker->domainName,
+        'price' => \random_int(1, 100),
+        'quantity' => \random_int(0, 10),
+    ];
+});