Merge pull request #901 from bavix/phpstan-fix

rez1dent3 · web-flow · commit 7b1ed1746d57 · 2024-02-28T22:34:16.000+03:00
phpstan fix
diff --git a/src/Models/Transaction.php b/src/Models/Transaction.php
@@ -46,7 +46,7 @@ class Transaction extends Model
     final public const TYPE_WITHDRAW = 'withdraw';
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = [
         'payable_type',
diff --git a/src/Models/Transfer.php b/src/Models/Transfer.php
@@ -49,7 +49,7 @@ class Transfer extends Model
     final public const STATUS_GIFT = 'gift';
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = [
         'status',
diff --git a/src/Models/Wallet.php b/src/Models/Wallet.php
@@ -57,7 +57,7 @@ class Wallet extends Model implements Customer, WalletFloat, Confirmable, Exchan
     use SoftDeletes;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = [
         'holder_type',
diff --git a/tests/Infra/Models/Item.php b/tests/Infra/Models/Item.php
@@ -29,7 +29,7 @@ final class Item extends Model implements ProductLimitedInterface
     use HasWallets;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price'];
 
diff --git a/tests/Infra/Models/ItemDiscount.php b/tests/Infra/Models/ItemDiscount.php
@@ -24,7 +24,7 @@ final class ItemDiscount extends Model implements ProductLimitedInterface, Disco
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price'];
 
diff --git a/tests/Infra/Models/ItemDiscountTax.php b/tests/Infra/Models/ItemDiscountTax.php
@@ -25,7 +25,7 @@ final class ItemDiscountTax extends Model implements ProductLimitedInterface, Di
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price'];
 
diff --git a/tests/Infra/Models/ItemMaxTax.php b/tests/Infra/Models/ItemMaxTax.php
@@ -24,7 +24,7 @@ final class ItemMaxTax extends Model implements ProductLimitedInterface, Maximal
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price'];
 
diff --git a/tests/Infra/Models/ItemMeta.php b/tests/Infra/Models/ItemMeta.php
@@ -25,7 +25,7 @@ final class ItemMeta extends Model implements ProductLimitedInterface
     use HasWallets;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price'];
 
diff --git a/tests/Infra/Models/ItemMinTax.php b/tests/Infra/Models/ItemMinTax.php
@@ -24,7 +24,7 @@ final class ItemMinTax extends Model implements ProductLimitedInterface, Minimal
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price'];
 
diff --git a/tests/Infra/Models/ItemMultiPrice.php b/tests/Infra/Models/ItemMultiPrice.php
@@ -25,7 +25,7 @@ final class ItemMultiPrice extends Model implements ProductLimitedInterface
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price', 'prices'];
 
diff --git a/tests/Infra/Models/ItemTax.php b/tests/Infra/Models/ItemTax.php
@@ -24,7 +24,7 @@ final class ItemTax extends Model implements ProductLimitedInterface, Taxable
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price'];
 
diff --git a/tests/Infra/Models/ItemWallet.php b/tests/Infra/Models/ItemWallet.php
@@ -25,7 +25,7 @@ final class ItemWallet extends Model implements ProductLimitedInterface
     use HasWallets;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'quantity', 'price'];
 
diff --git a/tests/Infra/Models/Manager.php b/tests/Infra/Models/Manager.php
@@ -19,7 +19,7 @@ final class Manager extends Model implements Wallet
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'email'];
 }
diff --git a/tests/Infra/Models/User.php b/tests/Infra/Models/User.php
@@ -19,7 +19,7 @@ final class User extends Model implements Wallet
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'email'];
 }
diff --git a/tests/Infra/Models/UserConfirm.php b/tests/Infra/Models/UserConfirm.php
@@ -22,7 +22,7 @@ final class UserConfirm extends Model implements Wallet, Confirmable
     use CanConfirm;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'email'];
 
diff --git a/tests/Infra/Models/UserDynamic.php b/tests/Infra/Models/UserDynamic.php
@@ -19,7 +19,7 @@ final class UserDynamic extends Model implements Wallet
     use HasWallet;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'email'];
 
diff --git a/tests/Infra/Models/UserFloat.php b/tests/Infra/Models/UserFloat.php
@@ -20,7 +20,7 @@ final class UserFloat extends Model implements Wallet, WalletFloat
     use HasWalletFloat;
 
     /**
-     * @var string[]
+     * @var array<int, string>
      */
     protected $fillable = ['name', 'email'];
 
diff --git a/tests/Units/Domain/CartReceivingTest.php b/tests/Units/Domain/CartReceivingTest.php
@@ -103,6 +103,7 @@ public function testPay(): void
         self::assertCount(10, $cart->getItems());
 
         foreach ($cart->getItems() as $product) {
+            /** @var Item $product */
             self::assertSame(0, $product->getWallet('dollar')?->balanceInt);
         }
 
diff --git a/tests/Units/Domain/WalletTest.php b/tests/Units/Domain/WalletTest.php
@@ -306,11 +306,19 @@ public function testGetDynamicDefaultSlug(): void
     {
         /** @var UserDynamic $user */
         $user = UserDynamicFactory::new()->create();
+        self::assertFalse($user->relationLoaded('wallet'));
 
         self::assertNotNull($user->deposit(100));
         self::assertSame(100, $user->balanceInt);
 
+        self::assertTrue($user->relationLoaded('wallet'));
         self::assertSame('default-'.$user->email, $user->wallet->slug);
+
+        /** @var UserDynamic $userFound */
+        $userFound = UserDynamic::query()->find($user->getKey());
+
+        self::assertFalse($userFound->relationLoaded('wallet'));
+        self::assertSame('default-'.$user->email, $userFound->wallet->slug);
     }
 
     public function testCrash(): void
