add MinimalTaxable

Author: rez1dent3

changelog.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Add confirm method's
 - Add method `hasWallet`
 - Add currency service (create usd, eur,...)
+- Add `MinimalTaxable`
 
 ## [3.0.4] - 2019-07-22
 ### Fixed

src/Interfaces/MinimalTaxable.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Bavix\Wallet\Interfaces;
+
+interface MinimalTaxable extends Taxable
+{
+    /**
+     * @return int
+     */
+    public function getMinimalFee(): int;
+}

src/Services/WalletService.php

@@ -3,6 +3,7 @@
 namespace Bavix\Wallet\Services;
 
 use Bavix\Wallet\Exceptions\AmountInvalid;
+use Bavix\Wallet\Interfaces\MinimalTaxable;
 use Bavix\Wallet\Interfaces\Taxable;
 use Bavix\Wallet\Interfaces\Wallet;
 use Bavix\Wallet\Models\Wallet as WalletModel;
@@ -21,11 +22,25 @@ class WalletService
      */
     public function fee(Wallet $wallet, int $amount): int
     {
+        $result = 0;
+
         if ($wallet instanceof Taxable) {
-            return (int) ($amount * $wallet->getFeePercent() / 100);
+            $result = (int) ($amount * $wallet->getFeePercent() / 100);
+
+            /**
+             * Added minimum commission condition
+             *
+             * @see https://github.com/bavix/laravel-wallet/issues/64#issuecomment-514483143
+             */
+            if ($wallet instanceof MinimalTaxable) {
+                $minimal = $wallet->getMinimalFee();
+                if ($result < $minimal) {
+                    $result = $wallet->getMinimalFee();
+                }
+            }
         }
 
-        return 0;
+        return $result;
     }
 
     /**

tests/MinTaxTest.php

@@ -0,0 +1,60 @@
+<?php
+
+namespace Bavix\Wallet\Test;
+
+use Bavix\Wallet\Models\Transaction;
+use Bavix\Wallet\Test\Models\Buyer;
+use Bavix\Wallet\Test\Models\ItemMinTax;
+
+class MinTaxTest extends TestCase
+{
+
+    /**
+     * @return void
+     */
+    public function testPay(): void
+    {
+        /**
+         * @var Buyer $buyer
+         * @var ItemMinTax $product
+         */
+        $buyer = factory(Buyer::class)->create();
+        $product = factory(ItemMinTax::class)->create([
+            'quantity' => 1,
+        ]);
+
+        $fee = (int)($product->price * $product->getFeePercent() / 100);
+        if ($fee < $product->getMinimalFee()) {
+            $fee = $product->getMinimalFee();
+        }
+
+        $balance = $product->price + $fee;
+
+        $this->assertEquals($buyer->balance, 0);
+        $buyer->deposit($balance);
+
+        $this->assertNotEquals($buyer->balance, 0);
+        $transfer = $buyer->pay($product);
+        $this->assertNotNull($transfer);
+
+        /**
+         * @var Transaction $withdraw
+         * @var Transaction $deposit
+         */
+        $withdraw = $transfer->withdraw;
+        $deposit = $transfer->deposit;
+
+        $this->assertEquals($withdraw->amount, -$balance);
+        $this->assertEquals($deposit->amount, $product->getAmountProduct());
+        $this->assertNotEquals($deposit->amount, $withdraw->amount);
+        $this->assertEquals($transfer->fee, $fee);
+
+        $buyer->refund($product);
+        $this->assertEquals($buyer->balance, $deposit->amount);
+        $this->assertEquals($product->balance, 0);
+
+        $buyer->withdraw($buyer->balance);
+        $this->assertEquals($buyer->balance, 0);
+    }
+
+}

tests/Models/ItemMinTax.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Bavix\Wallet\Test\Models;
+
+use Bavix\Wallet\Interfaces\MinimalTaxable;
+
+class ItemMinTax extends Item implements MinimalTaxable
+{
+
+    /**
+     * @inheritDoc
+     */
+    public function getTable(): string
+    {
+        return 'items';
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getFeePercent(): float
+    {
+        return 3;
+    }
+
+    /**
+     * @return int
+     */
+    public function getMinimalFee(): int
+    {
+        return 90;
+    }
+
+}

tests/factories/ItemMinTaxFactory.php

@@ -0,0 +1,23 @@
+<?php
+
+use Bavix\Wallet\Test\Models\ItemMinTax;
+use Faker\Generator as Faker;
+
+/*
+|--------------------------------------------------------------------------
+| Model Factories
+|--------------------------------------------------------------------------
+|
+| This directory should contain each of the model factory definitions for
+| your application. Factories provide a convenient way to generate new
+| model instances for testing / seeding your application's database.
+|
+*/
+
+$factory->define(ItemMinTax::class, function (Faker $faker) {
+    return [
+        'name' => $faker->domainName,
+        'price' => random_int(1, 100),
+        'quantity' => random_int(0, 10),
+    ];
+});